Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The price is rounded down when using comma instead of dot in the price format #277

Open
AndreeaCristinaRadacina opened this issue Mar 29, 2024 · 2 comments
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@AndreeaCristinaRadacina

Description

A user reported that the price appears weird on the product page.

ref: https://wordpress.org/support/topic/option-are-weirdly-presented-in-subtotal-list/#post-17538113

I am not sure if it's a bug or a feature request for providing support for commas.

Step-by-step reproduction instructions

  1. Add a checkbox
  2. Insert two options: Test - 1,50 and Test2 - 2,50
  3. Save and check the product

It appears correctly when using 1.50 instead of 1,50.

Screenshots, screen recording, code snippet or Help Scout ticket

image image

Environment info

No response

Is the issue you are reporting a regression

No

@AndreeaCristinaRadacina AndreeaCristinaRadacina added the bug This label could be used to identify issues that are caused by a defect in the product. label Mar 29, 2024
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Mar 29, 2024
@AndreeaCristinaRadacina
Copy link
Author

AndreeaCristinaRadacina commented May 18, 2024

+1 https://wordpress.org/support/topic/price-is-not-transferred-correctly/#post-17764859

Same issue for comma used in the Add-on price.

@Soare-Robert-Daniel
Copy link
Contributor

Soare-Robert-Daniel commented Aug 23, 2024

This happens because some countries (like Romania) use , instead of . We should advise them only to use . because we do not have regional support for number formatting.

We can implement a warning for this situation or just auto-convert to . format.

@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Development

No branches or pull requests

3 participants