Compatibility issue Orbit Fox- Elementor Pro

[AndreeaCristinaRadacina]

Description

Users reported incompatibility issues between Orbit Fox and Elementor Pro.

I was not able to replicate it.

Step-by-step reproduction instructions

1. Install Elementor and Elementor Pro
2. Install Orbit Fox
3. Update WP to the latest version

Screenshots, screen recording, code snippet or Help Scout ticket

https://secure.helpscout.net/conversation/2569937337/413766/

system-info-www.enablersofchange.com.au-15-04-2024.txt

Environment info

No response

Is the issue you are reporting a regression

Yes, this is a regression.

[AndreeaCristinaRadacina]

+1 https://secure.helpscout.net/conversation/2570353120/413830?viewId=931544

[vytisbulkevicius]

@AndreeaCristinaRadacina,

We haven't made a release for 3 weeks, so I wouldn't call this a regression. I see Elementor made a release today and both tickets are submitted today, so it seems like the issue was introduced by Elementor release.

Also, the error is also thrown by Elementor not OrbitFox:

@preda-bogdan, can you also take a look when you can to see if it's a problem that should be fixed from our end?

[preda-bogdan]

@vytisbulkevicius it is caused by https://github.com/Codeinwp/elementor-extra-widgets which is a dependency of OBFX and it will trigger and error inside the new version of Elementor Pro because of this line here:https://github.com/Codeinwp/elementor-extra-widgets/blob/master/class-elementor-extra-widgets.php#L139 this should return the $data instead of NULL to not crash the editor on the newer versions od Elementor PRO.
You can assign this to me and I can take care of resolving this.

[preda-bogdan]

I've patched the issue in the linked package, updated the dependency, and prepared a release.
I've skipped the code review as the change was very small.
cc: @vytisbulkevicius
Do you want me to do a release?