Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new X icon #838

Merged
merged 4 commits into from
Mar 26, 2024
Merged

fix: use new X icon #838

merged 4 commits into from
Mar 26, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Mar 25, 2024

Summary

  • Updated the Socicon to the latest version.
  • Added new Twitter Logo as SVG and necessary CSS to keep the formating.

Will affect visual aspect of the product

YES

Screenshots

Before

Screenshot 2024-03-25 at 17 24 24

After

Screenshot 2024-03-25 at 17 23 39

image

Test instructions

  • In the Social Sharing Module activate the Twitter logo.
  • Check the page on both desktop and mobile.

Check before Pull Request is ready:

Closes #836

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 25, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Mar 25, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Mar 25, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Mar 25, 2024

Plugin build for 3b7e1c8 is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Mar 25, 2024 that may be closed by this pull request
@preda-bogdan preda-bogdan merged commit d018f75 into development Mar 26, 2024
6 checks passed
@preda-bogdan preda-bogdan deleted the fix/twitter-new-icon branch March 26, 2024 10:19
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.10.35 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Twitter icon/name
3 participants