page builder full width is broken

[ineagu]

https://www.dropbox.com/s/v59oykuvndd46kb/Screenshot%202019-02-01%2017.56.22.png?dl=0

cc @selul @contactashish13 I see this for obfx page builder full width on wp 5.0.3 and Gutenberg with twentynineteen, when I try to set this template to a page, the page goes blank.

[selul]

@ineagu i think this is the right behavior 🤔 I've tried to wp4.9.9 using the classic editor and twenty eighteen theme and was doing the same.

@abaicus what do you think?

[ineagu]

1st. In my screenshot you can see those weird characters in the name, I don't think is ok
2nd. If is broken on 4.9.9 with classic, I don't think is normal ;)), I mean not sure what you got, but I got a completely white screen, like sort of fatal error when viewing.

[cristian-ungureanu]

@ineagu harr characters are from an arrow in the name of the template. I think gutenberg is not decoding character codes. In 4.9 it displays " -» Page Builder Full Width". And I think that template is not full width but blank, the name is misleading, is the one where we don't render header and footer. There are cases when users are asking how to remove the menu on their page built with Elementor so they need to switch to that template.

…

On Sun, Feb 3, 2019, 6:51 PM Ionut Neagu ***@***.***> wrote: 1st. In my screenshot you can see those weird characters in the name, I don't think is ok 2nd. If is broken on 4.9.9 with classic, I don't think is normal ;)), I mean not sure what you got, but I got a completely white screen, like sort of fatal error when viewing. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#334 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJeDUWI0x0tlmBvsbDzMRcKKjmpTmU8Xks5vJxN7gaJpZM4aezHP> .

[selul]

1st yes, i get that char issue, i was talking about 2. Indeed i get the same thing as you on 4.9.9, the wsod.

[ineagu]

@cristian-ungureanu ok, it seems then that somewhere in the annals of composer the functionality got messed up.

I looked more into it and it seems there is a bug where the page template doesn't work if Elementor is not present :

With Elementor installed: https://www.dropbox.com/s/6h1s2v624p6o4nh/Screenshot%202019-02-04%2010.22.14.png?dl=0
Without Elementor https://www.dropbox.com/s/5mh7s18ec4bzsd7/Screenshot%202019-02-04%2010.23.13.png?dl=0

I guess what you are talking about are the page builder full width and full width blank templates.

[ineagu]

@selul is particularly useful since we can re-use the same composer package and even rebrand the elementor page templater plugin to work for gutenberg too since we have a custom implementation for lots of themes who doesn't have a full width template

[selul]

I have fixed the strange char issue and added the template usability for Gutenberg or default editor.
For now it just renders the post content