Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer search module #124

Open
abaicus opened this issue Nov 23, 2017 · 9 comments
Open

Customizer search module #124

abaicus opened this issue Nov 23, 2017 · 9 comments
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project feature

Comments

@abaicus
Copy link
Contributor

abaicus commented Nov 23, 2017

Maybe we can build a JS library which we can include in themes to add a search option between customizer options. As we add more options there, the more complicated is to find a setting which you need edit.

@selul selul added the enhancement Request to improve or optimize an existing feature or functionality in the project label Dec 5, 2017
@andreilupu
Copy link
Contributor

As a reminder: There is this plugin https://wordpress.org/plugins/customizer-search
It not even close a thing that I would finally use, but it's a start, and it proves that it can be done.

@andreilupu
Copy link
Contributor

I've started to work on this issue, and I have a UI dilemma.
Should we place the search bar top? Or keep it close to the customizer controls?

Here's a mockup compare
https://projects.invisionapp.com/freehand/document/qLP3kdnne

@ineagu
Copy link
Contributor

ineagu commented Jan 8, 2018

From my perspective this would be very subtle integrated into customizer, like a search icon only, either in the you are customizing or the active theme section. when clikcing on the search icon we will show the search input. The module would be activated by default as well in obfx.

this issue could be proved complex from an UX perspective, I mean how we show the search results, unless we can get a quick good enough solution there is not point to work on it for more than a day.

@andreilupu
Copy link
Contributor

I understand. Well, until now I've come to these conclusions:

  • I would go with the bottom position since it is a general Customizer control and not a theme specific.
  • I would go with a Select2 autocomplete drop-down except that when the user clicks a result, it would instantly focus the setting directly and apply an outline to it.
  • It should be a small standalone library which should automatically hook customizer settings. This means that it could eventually be placed in obfx or any plugin.

I find the above solution the simplest way as UI and implementation, but one day is a very ambitious estimation which I would gladly take it as a challenge. 😄 ( <- only if we decide to go this way)

@ineagu
Copy link
Contributor

ineagu commented Jan 8, 2018 via email

@selul
Copy link
Contributor

selul commented Jan 8, 2018

@andreilupu yes, the bottom search solution looks amazing for me but i don't know how this will look with the autocomplete list.
Will be more difficult to filter the customizer sections on the fly, by hiding/showing them, if they match the search query ?

@andreilupu
Copy link
Contributor

@selul I find that approach very difficult because the settings are split into panels/sections and it is very hard to display two settings from different panels at the same time. Also, some settings may not be loaded as HTML while searching.
It should be possible, but it would require a lot of extra time.

@selul
Copy link
Contributor

selul commented Jan 9, 2018

@andreilupu then let's keep the autocomplete list.

@ineagu
Copy link
Contributor

ineagu commented Sep 4, 2020

@selul this can be a good little thing to revive, pixelgrade customify plugin has a solution, astra as well, probably we can go with something simple.

Not sure if another solution won't be to simply recommend this within docs + recommended plugins list: https://wordpress.org/plugins/customizer-search/ ( if is not too intrusive).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project feature
Projects
None yet
Development

No branches or pull requests

5 participants