-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TBD] feat: template cloud integration #2455
base: development
Are you sure you want to change the base?
Conversation
Bundle Size Diff
|
Plugin build for 99042ae is ready 🛎️!
|
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 242.6, firstPaint: 568.9, domContentLoaded: 1551.15, loaded: 1551.85, firstContentfulPaint: 3545, firstBlock: 7855.25, type: 13.5, minType: 10.84, maxType: 19.35, typeContainer: 8.55, minTypeContainer: 7.64, maxTypeContainer: 9.68, focus: 33.42, minFocus: 29.28, maxFocus: 39.57, inserterOpen: 21.74, minInserterOpen: 19.68, maxInserterOpen: 24.55, inserterSearch: 0.66, minInserterSearch: 0.56, maxInserterSearch: 0.86, inserterHover: 3.37, minInserterHover: 3.04, maxInserterHover: 4.38, listViewOpen: 137.41, minListViewOpen: 127.11, maxListViewOpen: 146.43 |
@abaicus I had a chance to review this and here are some thoughts based on the updated implementation:
a) Display a link at the top like : https://vertis.d.pr/i/6Lt1sR, when clicked, it would open on the right some text explaining this + a link to the settings ( is this possible? b) Since most of users won't use this, we can display that link at the bottom, after the categories.
Eventually later on we can also encourage users to share their collections if they want or we can create some more, free or paid. To recap :
|
Closes Codeinwp/templates-cloud#98.
Summary
Screenshots
Test instructions
Checklist before the final review