Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TBD] feat: template cloud integration #2455

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

abaicus
Copy link
Contributor

@abaicus abaicus commented Nov 22, 2024

Closes Codeinwp/templates-cloud#98.

Summary

Screenshots


Test instructions


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@abaicus abaicus changed the base branch from master to development November 22, 2024 17:17
@abaicus abaicus marked this pull request as ready for review November 22, 2024 17:18
@abaicus abaicus changed the title feat: template cloud integration [ref Codeinwp/templates-cloud#98] [TBD] feat: template cloud integration Nov 22, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 22, 2024
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.41 KB 271.41 KB 0 B (0.00%)
Blocks 1.56 MB 1.56 MB 503 B (0.03%)
CSS 100.89 KB 100.89 KB 0 B (0.00%)
Dashboard 197.17 KB 203.35 KB 6.18 KB (3.14%)
Onboarding 161.1 KB 161.1 KB 0 B (0.00%)
Export Import 97.78 KB 97.78 KB 0 B (0.00%)
Pro 423.65 KB 423.65 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for 99042ae is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 242.6, firstPaint: 568.9, domContentLoaded: 1551.15, loaded: 1551.85, firstContentfulPaint: 3545, firstBlock: 7855.25, type: 13.5, minType: 10.84, maxType: 19.35, typeContainer: 8.55, minTypeContainer: 7.64, maxTypeContainer: 9.68, focus: 33.42, minFocus: 29.28, maxFocus: 39.57, inserterOpen: 21.74, minInserterOpen: 19.68, maxInserterOpen: 24.55, inserterSearch: 0.66, minInserterSearch: 0.56, maxInserterSearch: 0.86, inserterHover: 3.37, minInserterHover: 3.04, maxInserterHover: 4.38, listViewOpen: 137.41, minListViewOpen: 127.11, maxListViewOpen: 146.43

@ineagu
Copy link
Contributor

ineagu commented Nov 23, 2024

@abaicus I had a chance to review this and here are some thoughts based on the updated implementation:

  1. Since we moved adding sources in the settings, I would also move the initially suggested message to clarify what this is about : https://vertis.d.pr/i/RVz5VW (using links and adapting the design).

  2. My initial idea was that the "My Library" link would still be displayed even if no sources are added and would act as a upsell/feature discovery. Considering the new implementation I see 2 ideas:

a) Display a link at the top like : https://vertis.d.pr/i/6Lt1sR, when clicked, it would open on the right some text explaining this + a link to the settings ( is this possible?

b) Since most of users won't use this, we can display that link at the bottom, after the categories.

  1. I guess a concern you also had and decided not to show the link if there are no sources is how useful this would be for Otter users, we can open up quite easily a lot more possibilities and make this more useful if for example we suggest users a doc in which we would share for the start a free collection ( I can easily do that with some material design patterns that John created + install TC server on demosites).

Eventually later on we can also encourage users to share their collections if they want or we can create some more, free or paid.

To recap :

  1. We need to fix
  2. I need to be clear if it possible and what makes sense for you a or b
  3. I need your thoughts on potential technical challenges + on the idea itself. If we skip this, we can move with 2 b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants