Fix Buton Group Font settings #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirate-bot
added
the
pr-checklist-complete
Bundle Size Diff
|
|
Plugin build for 46a2891 is ready 🛎️!
|
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 223.8, firstPaint: 130.15, domContentLoaded: 1594.4, loaded: 1594.95, firstContentfulPaint: 3749.85, firstBlock: 5758.35, type: 13.33, minType: 12.09, maxType: 15.98, typeContainer: 8.51, minTypeContainer: 7.08, maxTypeContainer: 11.4, focus: 43.51, minFocus: 34.31, maxFocus: 56.66, inserterOpen: 27.43, minInserterOpen: 24.99, maxInserterOpen: 33.98, inserterSearch: 6.28, minInserterSearch: 5.9, maxInserterSearch: 6.85, inserterHover: 3.86, minInserterHover: 3.52, maxInserterHover: 4.66, listViewOpen: 149.17, minListViewOpen: 136.7, maxListViewOpen: 169.71 |
HardeepAsrani
approved these changes
Jun 24, 2024
| @@ -157,7 +157,7 @@ public function render_css( $block ) { | |||
| 'property' => 'line-height', | |||
| 'value' => 'lineHeight', | |||
| 'format' => function( $value, $attrs ) { | |||
| return is_numeric( $value ) ? $value . 'px' : $value; | |||
| return ! is_string( $value ) && is_numeric( $value ) ? $value . 'px' : $value; | |||
There was a problem hiding this comment.
Did you test it with legacy blocks to confirm this works as well with everything?
There was a problem hiding this comment.
By legacy, I will refer to the first version, which used the int as values. Those will be the same since they will be pixels.
The more recent version, which uses the unit input field, is now fixed when using the unitless mode.
|
@Soare-Robert-Daniel tested and everything works well 👍 |
|
🎉 This PR is included in version 2.6.13 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2163
Summary
Note
Be aware of #2177
Screenshots
Test instructions
Checklist before the final review