Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG files are pixelated when best format is served for them #847

Open
kushh23 opened this issue Oct 24, 2024 · 3 comments
Open

SVG files are pixelated when best format is served for them #847

kushh23 opened this issue Oct 24, 2024 · 3 comments
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Milestone

Comments

@kushh23
Copy link

kushh23 commented Oct 24, 2024

Description

If an SVG file is served using the best format feature, then those files become pixelated. When we remove the f:best from the URL, it is served properly.

Step-by-step reproduction instructions

  1. Use an SVG logo file.
  2. Enable the best format option.
  3. Check the file, it is a little pixelated.
  4. Disable the best format option and check again.

Screenshots, screen recording, code snippet or Help Scout ticket

Without Best format:
https://mlmqtf9kyudb.i.optimole.com/cb:sZ8K.4f35c/w:auto/h:auto/q:mauto/ig:avif/https://skadedjursfritt.nu/wp-content/uploads/2023/09/skadedjursfritt-logga-vit-liggande.svg

With best format:
https://mlmqtf9kyudb.i.optimole.com/cb:sZ8K.4f35c/f:best/w:auto/h:auto/q:mauto/ig:avif/https://skadedjursfritt.nu/wp-content/uploads/2023/09/skadedjursfritt-logga-vit-liggande.svg

Reported here - https://secure.helpscout.net/conversation/2742499960/438306

Environment info

No response

Is the issue you are reporting a regression

No

@kushh23 kushh23 added the bug This label could be used to identify issues that are caused by a defect in the product. label Oct 24, 2024
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Oct 24, 2024
@kushh23
Copy link
Author

kushh23 commented Feb 27, 2025

It can be solved by IMGPROXY_BEST_FORMAT_ALLOW_SKIPS

@vytisbulkevicius vytisbulkevicius added this to the 4.0 milestone Mar 2, 2025
@vytisbulkevicius vytisbulkevicius added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Mar 11, 2025
@selul selul self-assigned this Mar 11, 2025
@selul
Copy link
Contributor

selul commented Mar 21, 2025

Seems like the image from imgproxy had a bug here which they fixed recently.I've updated that and is working as expected now. Please test on staging.

@kushh23
Copy link
Author

kushh23 commented Mar 21, 2025

@selul tested with the staging and this bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Development

No branches or pull requests

4 participants