Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error when upgrading to latest version #790

Closed
rodica-andronache opened this issue Apr 16, 2024 · 3 comments
Closed

Fatal error when upgrading to latest version #790

rodica-andronache opened this issue Apr 16, 2024 · 3 comments
Labels
bug This label could be used to identify issues that are caused by a defect in the product. regression Issue represents a change in behavior from a previous version that is not intended or desired..

Comments

@rodica-andronache
Copy link

Description

On a couple of sites where I had Optimole installed, when I upgraded to the latest version, I got a fatal error. On a third one I didn't get the fatal error. I don't know the setup exactly.

Screenshot on 2024-04-16 at 14-36-37
Screenshot on 2024-04-16 at 14-37-05

Step-by-step reproduction instructions

I can't provide specific instructions. On 2 out of 3 sites where I had Optimole installed, the fatal error appeared.

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

Yes, this is a regression.

@rodica-andronache rodica-andronache added the bug This label could be used to identify issues that are caused by a defect in the product. label Apr 16, 2024
@pirate-bot pirate-bot added the regression Issue represents a change in behavior from a previous version that is not intended or desired.. label Apr 16, 2024
@preda-bogdan
Copy link
Contributor

I think it might come from Sparks or other plugins that will use the _lc_no_valid_string that when using the latest version of the SDK will not match on the new format.

@selul
Copy link
Contributor

selul commented Apr 16, 2024

Checking.

@selul
Copy link
Contributor

selul commented Apr 16, 2024

Fixed this here Codeinwp/themeisle-sdk@d4545f9 and released here #791

Thanks @preda-bogdan and @rodica-andronache for help 🙏

@selul selul closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. regression Issue represents a change in behavior from a previous version that is not intended or desired..
Projects
None yet
Development

No branches or pull requests

4 participants