Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Conflict with Funnelkit Product Thumbnail when Item count is increased #782

Open
isaumya opened this issue Mar 26, 2024 · 0 comments
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.

Comments

@isaumya
Copy link

isaumya commented Mar 26, 2024

Description

The issue is reported here: https://wordpress.org/support/topic/woo-commerce-cart-problem/
The problem is that when a website is using Funnelkit checkout pages for WooCommerce. If you add a product to cart and then go to the checkout page, if you keep increasing the item count, when you reach 7 count the checkout page will break.

I've already analyzed the issue and the root cause behind this issue is a wrong string concatenation inside the JSON response that is sent when you increase the item count and a POST request is sent to /?wc-ajax=update_order_review&wfacp_id=56501&wfacp_is_checkout_override=yes

For example, when you do not get the error, you will see that the request to https://www.staging18.masacoustics.it/?wc-ajax=update_order_review&wfacp_id=56501&wfacp_is_checkout_override=yes will have a response like this: https://i.imgur.com/LKVYPuS.jpeg and https://i.imgur.com/zmCZxHB.jpeg

And when it breaks, you can clearly see the JSON being broken: https://i.imgur.com/7GnkBB7.jpeg and https://i.imgur.com/av3PLuP.jpeg

Step-by-step reproduction instructions

  1. Go to https://www.staging18.masacoustics.it/shop/isolamento-acustico/barriera-acustica-flat-barrier-10a/
  2. Check on add to cart button (https://i.imgur.com/8Bjz8zE.jpeg)
  3. Now go to the cart (https://i.imgur.com/e8Oj7MZ.jpeg)
  4. Now keep increasing the item count (https://i.imgur.com/p576EdL.jpeg) until the the section just keeps on looping the loading animation
  5. Keep an eye on the network tab of the browser console so that you can spot the issue with the JSON response count from /?wc-ajax=update_order_review requests

Screenshots, screen recording, code snippet or Help Scout ticket

Video demonstration of the issue: https://mega.nz/file/qUcUGRbB#Glix4VsgKthAI_zDTYBS9lDp_s1lrQy3LNESPIYQD2E

Environment info

No response

Is the issue you are reporting a regression

No

@isaumya isaumya added the bug This label could be used to identify issues that are caused by a defect in the product. label Mar 26, 2024
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.
Projects
None yet
Development

No branches or pull requests

2 participants