Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small visual issue with external link icon #634

Closed
selul opened this issue Aug 9, 2023 · 2 comments · Fixed by #648
Closed

Small visual issue with external link icon #634

selul opened this issue Aug 9, 2023 · 2 comments · Fixed by #648
Assignees
@HardeepAsrani
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Milestone
3.10

Comments

@selul
Copy link
Contributor

selul commented Aug 9, 2023 •
edited
Loading

Description

Right now the external icon is going on a new line, causing a visual glitch. Would be ideal to have them on the same line for a more appealing UI.

Step-by-step reproduction instructions

https://vertis.d.pr/i/hWo0TI

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

Optimole: 3.9.1
https://www.whatsmybrowser.org/b/18ZSO
WP Version: 6.3

Is the issue you are reporting a regression

No
@selul selul added the bug This label could be used to identify issues that are caused by a defect in the product. label Aug 9, 2023
@abaicus abaicus added this to the 3.10 milestone Aug 21, 2023
@abaicus
Copy link
Contributor

abaicus commented Aug 21, 2023

I think we can set that link to display inline-block to ensure all the words stay together.

@HardeepAsrani HardeepAsrani added the tiny (1h) - This label is used for issues that can be completed in under an hour. label Aug 23, 2023
HardeepAsrani added a commit that referenced this issue Aug 23, 2023
@HardeepAsrani
fix: external link on a new line [ref: #634]
9a13967
@HardeepAsrani HardeepAsrani mentioned this issue Aug 23, 2023
Merged
6 tasks
@HardeepAsrani HardeepAsrani linked a pull request Aug 23, 2023 that will close this issue
fix: external link on a new line #648
Merged
6 tasks
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 18, 2023
@abaicus abaicus closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HardeepAsrani HardeepAsrani

Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Projects
None yet
Milestone
3.10
Development

Successfully merging a pull request may close this issue.

fix: external link on a new line Codeinwp/optimole-wp
4 participants
@HardeepAsrani @selul @abaicus @pirate-bot