Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the generic lazyload placeholder to have a specific color instead of being transparent #624

Closed
Nazrinn opened this issue Aug 3, 2023 · 10 comments
Assignees
Labels
doc-created This label will be used after the doc-needed request has been satisfied. doc-needed This issue requires documentation updates or additions once it has been completed. medium (1d) - This label is used for issues that can be completed within 1 day or less. new feature Request for a new feature or functionality to be added to the project. product-milestone Important tasks for next product milestone. Prioritize these before others. released Indicate that an issue has been resolved and released in a particular version of the product.
Milestone

Comments

@Nazrinn
Copy link

Nazrinn commented Aug 3, 2023

What problem does this address?

I find it helpful when scrolling down a website to see exactly where images will appear. With a transparent placeholder, you can only assume where an image will appear due to layout spacing, but sometimes you expect an image where there is actually none and you end up waiting for nothing or thinking the website is broken because no image loaded.

What is your proposed solution?

Add the possibility to pick a color and alpha channel value for the generic lazyload placeholder, similar to how LiteSpeed Cache does it.

image

This might mean to add an image to the page, depending of the implementation.

Will this feature require documentation? (Optional)

Yes, it requires documentation.


Figma

@Nazrinn Nazrinn added the new feature Request for a new feature or functionality to be added to the project. label Aug 3, 2023
@pirate-bot pirate-bot added the doc-needed This issue requires documentation updates or additions once it has been completed. label Aug 3, 2023
@selul
Copy link
Contributor

selul commented Aug 4, 2023

@Nazrinn Thank you for the feature suggestion; it's definitely a great idea; we will consider this for the upcoming releases.

@selul selul added the product-milestone Important tasks for next product milestone. Prioritize these before others. label Aug 7, 2023
@AndreeaCristinaRadacina AndreeaCristinaRadacina added doc-created This label will be used after the doc-needed request has been satisfied. product-milestone Important tasks for next product milestone. Prioritize these before others. and removed product-milestone Important tasks for next product milestone. Prioritize these before others. doc-created This label will be used after the doc-needed request has been satisfied. labels Aug 18, 2023
@abaicus abaicus added this to the 3.10 milestone Aug 21, 2023
@abaicus
Copy link
Contributor

abaicus commented Aug 21, 2023

@Codeinwp/design-team, we need some control for the color of the image lazyload placeholder in the Optimole settings.

@abaicus abaicus self-assigned this Aug 21, 2023
@mghenciu
Copy link

https://github.com/orgs/Codeinwp/teams/design-team, we need some control for the color of the image lazyload placeholder in the Optimole settings.

I tried something in Figma.

From what I understood, this feature is related to Enable generic lazyload placeholder, but let me know if it should live inside another Panel.

image

@abaicus
Copy link
Contributor

abaicus commented Aug 21, 2023

@mghenciu Yes, that is right. It's tied to the generic placeholder. I think we should display it conditionally based on the status of the generic placeholder setting 👍🏻

@mghenciu
Copy link

Thank you Andrei for the quick response.
So I assume that option is ok to live inside the Enable generic lazyload placeholder panel, and visible only when enabled.

I'll just wait to see what @JohnPixle, thinks about it UI.

Also, I adjusted the text a bit, so it mentions the color and for a better writing. Ideally it should stay on 2 lines; if not - I'll try to make it a bit shorter.
image

@abaicus abaicus added small (1-3h) This label is used for issues that can be completed within 3 hours or less. medium (1d) - This label is used for issues that can be completed within 1 day or less. and removed small (1-3h) This label is used for issues that can be completed within 3 hours or less. labels Aug 21, 2023
@Nazrinn
Copy link
Author

Nazrinn commented Aug 21, 2023

@mghenciu please keep in mind that you could use a link to Optimole's documentation to keep the text shorter like I proposed in #621!

@JohnPixle
Copy link

JohnPixle commented Aug 22, 2023

@mghenciu looking good! It's a Tailwind component, right?

Switching the status to Ready for Dev. Thanks!

@abaicus
Copy link
Contributor

abaicus commented Aug 22, 2023

@mghenciu @JohnPixle, I agree that we should add a doc link instead of expanding the text. Here's how it will look:

image

image

@mghenciu
Copy link

mghenciu commented Aug 22, 2023

Looks good!
I think we can improve the text later, depending also on how we change the details in the docs.

Or we can go for something like this: Enabling this will replace the low-quality image with a generic transparent placeholder, reducing the number of requests and page weight. However, this might affect the user experience in some cases. More details here

basically explaining the feature.


@mghenciu looking good! It's a Tailwind component, right?

It's not in Tailwind, but we can use the Core one I think.

@AndreeaCristinaRadacina AndreeaCristinaRadacina added the doc-created This label will be used after the doc-needed request has been satisfied. label Aug 24, 2023
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-created This label will be used after the doc-needed request has been satisfied. doc-needed This issue requires documentation updates or additions once it has been completed. medium (1d) - This label is used for issues that can be completed within 1 day or less. new feature Request for a new feature or functionality to be added to the project. product-milestone Important tasks for next product milestone. Prioritize these before others. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

No branches or pull requests

7 participants