Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site text-color not used in edit pages or posts #4335

Open
rp78 opened this issue Nov 24, 2024 · 4 comments · May be fixed by #4337
Open

Site text-color not used in edit pages or posts #4335

rp78 opened this issue Nov 24, 2024 · 4 comments · May be fixed by #4337
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product.

Comments

@rp78
Copy link

rp78 commented Nov 24, 2024

Description

The site background-color is used on the pages and post editor, the text-color is not.
This will lead to issue when using a dark back-ground colour for your site.

Expected behaviour is that the selected text-color is also used on the page and post editors.

Step-by-step reproduction instructions

  1. Change the background colour of your site via the Customize. Choose a dark background-color (#0E1726) and a lighther text-color: (#EE9726)
    Image

  2. Go to a page and you can hardly read the text, because it is black on a dark background.

To fix it, I changed the CSS files in wp-content\themes\neve\assets\css

  • gutenberg-editor-style.css
  • gutenberg-editor-style.min.css

Added color: var(--nv-text-color) to .editor-styles-wrapper, .editor-styles-wrapper > *

I'm not a developer, but hope that this is a good way to fix this.

Screenshots, screen recording, code snippet or Help Scout ticket

This is the result without is the change in the CSS-files
Image

Environment info

https://pastebin.com/riStkfWN

Is the issue you are reporting a regression

No

@rp78 rp78 added the bug This label could be used to identify issues that are caused by a defect in the product. label Nov 24, 2024
@girishpanchal30
Copy link
Contributor

I've reviewed this issue and fixed it here - #4337

@rodica-andronache
Copy link
Contributor

tested and it's working well

@rodica-andronache
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants