-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Migrating Neve customizer options on install #2
Comments
That's right. When we create the Templates in the FSE theme we can create those mappings. In the FSE templates, we can also include variants for the sidebar, so we can get even more detailed with the mappings. For example: Sing Post templates (FSE)
Same for Archives, pages etc. |
Regarding the Fonts, I am not sure how we can make it work 🤔 Because in FSE we have Style Variations and all the font families are wrapped in the theme (no option to select from any google font). So what happens if a user in Classic Neve is using a Google Font and then migrates to the FSE? We will need to serve one of the fonts that are built-into the FSE theme. One thing that might make sense would be to include all the fonts pairings we have in Neve, in the Style Variations of the FSE. For example we can release the Neve FSE with 10-12 style variations which include the current font pairings. (And a different color palette for each variation ofc) cc @mghenciu |
Good ideas, John. One thing we need to clarify I think, is if this flow is actually what we want: as a existing Neve user, I want to install Neve FSE and all my settings/styles will be converted. My assumption is that we don't want this, at this point at least. Maybe letter. How we can approach this, is by going step by step in converting Neve Layouts in FSE, but stick to what's possible now, and don't force things. Color Palettes can be converted to variations, and so on. Another idea for the fonts, could be to implement it directly in the theme, or via a plugin . But I would recommend going simple overall, as things are still developing in FSE and probably they will add things that we are trying to fix now. For example we had an issue with Font Size on different screens, and as expected they added Fluid Typography which fixes this. LATER EDIT: I think there are already some talks how to add google fonts. |
In the meantime, I did an initial review on the Neve Customizer settings that are visible theme wise - and we can look into a replacements for them in FSE: Note: I think in the initial phase, we'll focus only on translating Free features in FSE. Sidebar, Blog and Page
Headers
Footer
Colors and Background
Typography
Form fields
Buttons
|
@mghenciu thanks a lot for sharing your thoughts on this. First, I agree with everything about the breakdown of the features you did above. Style variations / template variations / patterns are the way to go. Regarding:
I'd say that an approximate translation of the very basics will be enough, we cannot achieve 1:1, and we should not force ourselves to do so. I was thinking about migrating colors, fonts and conditionally serve a very basic layout that is similar to some of the existing customiser settings. For example,
We don't want to go crazy with details, we just want something that works in most of the cases. I believe that realistically, a big chunk of the users with heavily customised websites and plugins will try out Neve FSE on a new project, instead of switching themes on their existing active sites. But if we manage to provide a good UX for the users with simple Neve sites, then we an increase the number of active installs from the beginning. Let me know your thoughts. |
The user acquisition strategy makes sense, @JohnPixle, especially thinking of how many users use Neve. Another thing we'll need to think of in this time, is what benefits will Neve Pro retain. For example FSE has sticky header, which is part of Neve Pro now - meaning that we'll need to evaluate how to add more value in FSE, with Neve Pro. |
@mghenciu I was thinking that perhaps for the Header and Footer Builder we create at some point a custom block, where the user will build the element inside the FSE editor. This will require sidebar design for styling and settings etc, and apart from that, I have no idea if it's technically possible in the FSE Site Editor. We can also add a lot of premium patterns in Neve Pro, and these patterns can be useful to both Classic and Neve users. Thinking 🤔 |
@mghenciu and @JohnPixle I don't think we can add any form-related styles as @mghenciu mentioned. I think for the patterns and presets we already discussed this and the user can replace the template parts if defined as discussed here: #3 (comment) or use the defined patterns. Is there any other option that would require actions on my part on top of what we have now? You can use this PR #10 to check it contains all the mentioned changes. The only thing that is not present here is the new design. Let me know, thank you! |
We need to assess what Customizer options are critical and we want to migrate to the new theme.
@Codeinwp/design-team Here we will require your input on what options are the most important to have.
From previous comments we have:
The text was updated successfully, but these errors were encountered: