Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Proposal ] Freehand Mode #36

Open
Soare-Robert-Daniel opened this issue Apr 2, 2021 · 2 comments
Open

[ Proposal ] Freehand Mode #36

Soare-Robert-Daniel opened this issue Apr 2, 2021 · 2 comments
Assignees
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project help wanted This can be used to identify issues that the maintainers of the project would like some help with. proposal question Can be used to identify issues that are asking a question about the code or how to use the project.

Comments

@Soare-Robert-Daniel
Copy link
Collaborator

Introduction

The current layout settings on Logo Maker are based on predefined templates: TOP, LEFT RIGHT. I suggest adding one more option: Freehand - in which the user can drag the SVG to the desired positions.

Preview:
image

Implementation

For dragging the SVGs, we can use native functions based on mouse events - you can have a peak in this tutorial.

Besides the drag option, it will be nice to have a way to scale ( only the logo, slogan & text have this option via font-size in Typography ) or rotate. Scaling and rotating the SVG might some problems for the user with small screens. Unlike dragging which occurs on the mouse, these options will available via floating element - they will appear when you select an element.

Preview:
image

image

@ineagu, @HardeepAsrani, @selul, @mghenciu, @mileamadalin what do you think?

@Soare-Robert-Daniel Soare-Robert-Daniel added enhancement Request to improve or optimize an existing feature or functionality in the project help wanted This can be used to identify issues that the maintainers of the project would like some help with. question Can be used to identify issues that are asking a question about the code or how to use the project. proposal labels Apr 2, 2021
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Apr 2, 2021
@ineagu
Copy link

ineagu commented Apr 2, 2021

  1. I think we can bring the logo-size feature in the logo tab, maybe before displaying the 50 logos
  2. Definitively we can add freehand option if it's not too complicated, 1 sounds more important for me.

@mghenciu
Copy link

mghenciu commented Apr 5, 2021

@Soare-Robert-Daniel
Having the option to move the Logo sounds really good, especially for the cases where you need to optically align elements. Same thing for the rotation, it's a good idea, maybe for now it's worth adding it only for the logo (rotating the text I don't think has a lot of popularity).

Something to keep in mind about the moving option, is that usually you'll want to make small changes (in terms of moving distance), and make the moves as precise/frictionless as possible, that's why most of the time I use snapping options or I move the elements with arrow keys, knowing that each key tap has 8px.
Long story short, make sure that items move slowly (than usual) when you drag them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project help wanted This can be used to identify issues that the maintainers of the project would like some help with. proposal question Can be used to identify issues that are asking a question about the code or how to use the project.
Projects
None yet
Development

No branches or pull requests

3 participants