Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback image displayed even when it's not set #920

Closed
AndreeaCristinaRadacina opened this issue Apr 8, 2024 · 4 comments · Fixed by #929 or #933
Closed

Fallback image displayed even when it's not set #920

AndreeaCristinaRadacina opened this issue Apr 8, 2024 · 4 comments · Fixed by #929 or #933
Assignees
@Soare-Robert-Daniel
Labels
bug This label could be used to identify issues that are caused by a defect in the product. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@AndreeaCristinaRadacina
Copy link

Description

When using the Feedzy block in Gutenberg, the fallback image is displayed even if in the item options, it is set as "Yes, without a fallback image".

Step-by-step reproduction instructions

  1. Go to a page
  2. Add a Feedzy block
  3. Use a source like https://themeisle.com/blog/feed/
  4. Set the item image as "Yes, without a fallback image"

Screenshots, screen recording, code snippet or Help Scout ticket

image image

Environment info

No response

Is the issue you are reporting a regression

No
@AndreeaCristinaRadacina AndreeaCristinaRadacina added the bug This label could be used to identify issues that are caused by a defect in the product. label Apr 8, 2024
@AndreeaCristinaRadacina
Copy link
Author

One thing to note is that it doesn't happen for all feeds. For example, for https://www.codeinwp.com/feed/, it doesn't happen.

image

@AndreeaCristinaRadacina
Copy link
Author

A user also reported this - https://secure.helpscout.net/conversation/2560682406/412665/

@vytisbulkevicius
Copy link
Contributor

I think this bug occurs for items that don't have an image defined in the feed, if there is an image for an item in the feed this setting works and no image is shown.

@vytisbulkevicius vytisbulkevicius added the Priority-Medium Expected resolution time - up to 1 month. label Apr 8, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Apr 16, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this issue Apr 16, 2024
Merged
6 tasks
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Apr 17, 2024 that will close this issue
Better checking for default image for the RSS Block #929
Merged
6 tasks
@vytisbulkevicius vytisbulkevicius linked a pull request May 30, 2024 that will close this issue
Release #933
Merged
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 4.4.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
bug This label could be used to identify issues that are caused by a defect in the product. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
No milestone
4 participants
@Soare-Robert-Daniel @vytisbulkevicius @pirate-bot @AndreeaCristinaRadacina