Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"project_setup" incompatible with python_version > 3.7 #161

Open
jycordero opened this issue Mar 9, 2021 · 3 comments
Open

"project_setup" incompatible with python_version > 3.7 #161

jycordero opened this issue Mar 9, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed no-issue-activity

Comments

@jycordero
Copy link

jycordero commented Mar 9, 2021

Describe the bug

The logic in the project_setup makes it so that you are required to have python 3.7 installed, even though the language suggest that you could run it with higher versions. This is not a big problem, either make it clear that python 3.7 is the only supported version or change the logic so that is includes python_version > 3.7.

If the solution is to make clear that only python 3.7 is supported then people could be warned not to change the requirements on the Pipfile fo force to work with python 3.8.

To Reproduce

Steps to reproduce the behavior:
Un-install python3.7
install python3.8
setup stops and a message shows up

"Please install Python version 3.7.2 or greater"

Expected behavior
work with any version of python that is higher than 3.7

@github-actions
Copy link

github-actions bot commented Mar 9, 2021

Para nosotros toda contribución es importante. ¡Gracias por darnos de su tiempo y hacer tu primera contribución! Estaremos dandole un vistazo pronto.' first issue

@jycordero jycordero changed the title '" "project_setup" incompatible with python_version > 3.7 Mar 9, 2021
@jpadilla
Copy link
Contributor

Thanks for reporting this! I'm up for improving for sure. There's no real reason to pin specifically to 3.7, but I'd like to enforce >=3.7 somewhere(maybe version check in manage.py for example)

Pipenv makes this hard, so we could remove the python_version from there. We'd also have to tweak that project-setup script to account for that.

Interested in working on it?

@jpadilla jpadilla added enhancement New feature or request help wanted Extra attention is needed labels Mar 10, 2021
@github-actions
Copy link

This Issue is being marked as Stale because it has 30 days without any interaction. CC: @froi @jpadilla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants