make proto objects not optional by default (cline#5985)

Author: celestial-vault

proto/cline/common.proto

@@ -8,19 +8,16 @@ message Metadata {
 }
 
 message EmptyRequest {
-  Metadata metadata = 1;
 }
 
 message Empty {
 }
 
 message StringRequest {
-  Metadata metadata = 1;
   string value = 2;
 }
 
 message StringArrayRequest {
-  Metadata metadata = 1;
   repeated string value = 2;
 }
 
@@ -29,7 +26,6 @@ message String {
 }
 
 message Int64Request {
-  Metadata metadata = 1;
   int64 value = 2;
 }
 
@@ -38,7 +34,6 @@ message Int64 {
 }
 
 message BytesRequest {
-  Metadata metadata = 1;
   bytes value = 2;
 }
 
@@ -47,7 +42,6 @@ message Bytes {
 }
 
 message BooleanRequest {
-  Metadata metadata = 1;
   bool value = 2;
 }
 

proto/host/window.proto

@@ -4,8 +4,6 @@ package host;
 option java_package = "bot.cline.host.proto";
 option java_multiple_files = true;
 
-import "cline/common.proto";
-
 // Provides methods for working with IDE windows and editors.
 service WindowService {
   // Opens a text document in the IDE editor and returns editor information.
@@ -40,7 +38,6 @@ service WindowService {
 }
 
 message ShowTextDocumentRequest {
-  cline.Metadata metadata = 1;
   string path = 2;
   optional ShowTextDocumentOptions options = 3;
 }
@@ -59,7 +56,6 @@ message TextEditorInfo {
 }
 
 message ShowOpenDialogueRequest {
-  cline.Metadata metadata = 1;
   optional bool can_select_many = 2;
   optional string open_label = 3;
   optional ShowOpenDialogueFilterOption filters = 4;

scripts/build-proto.mjs

@@ -31,7 +31,7 @@ const TS_PROTO_OPTIONS = [
 	"esModuleInterop=true",
 	"outputServices=generic-definitions", // output generic ServiceDefinitions
 	"outputIndex=true", // output an index file for each package which exports all protos in the package.
-	"useOptionals=messages", // Message fields are optional, scalars are not.
+	"useOptionals=none", // scalar and message fields are required unless they are marked as optional.
 	"useDate=false", // Timestamp fields will not be automatically converted to Date.
 ]
 

src/integrations/diagnostics/__tests__/index.test.ts

@@ -47,6 +47,10 @@ describe("Diagnostics Tests", () => {
 						{
 							severity: DiagnosticSeverity.DIAGNOSTIC_ERROR,
 							message: "Error in file1",
+							range: {
+								start: { line: 0, character: 0 },
+								end: { line: 0, character: 10 },
+							},
 						},
 					],
 				},
@@ -114,6 +118,10 @@ describe("Diagnostics Tests", () => {
 						{
 							severity: DiagnosticSeverity.DIAGNOSTIC_ERROR,
 							message: "Error in file1",
+							range: {
+								start: { line: 0, character: 0 },
+								end: { line: 0, character: 10 },
+							},
 						},
 					],
 				},
@@ -125,6 +133,10 @@ describe("Diagnostics Tests", () => {
 						{
 							severity: DiagnosticSeverity.DIAGNOSTIC_ERROR,
 							message: "Error in file1",
+							range: {
+								start: { line: 0, character: 0 },
+								end: { line: 0, character: 10 },
+							},
 						},
 					],
 				},
@@ -134,6 +146,10 @@ describe("Diagnostics Tests", () => {
 						{
 							severity: DiagnosticSeverity.DIAGNOSTIC_ERROR,
 							message: "Error in file2",
+							range: {
+								start: { line: 0, character: 0 },
+								end: { line: 0, character: 10 },
+							},
 						},
 					],
 				},
@@ -198,6 +214,10 @@ describe("Diagnostics Tests", () => {
 						{
 							severity: DiagnosticSeverity.DIAGNOSTIC_WARNING,
 							message: "Warning message",
+							range: {
+								start: { line: 0, character: 0 },
+								end: { line: 0, character: 10 },
+							},
 						},
 					],
 				},
@@ -240,6 +260,10 @@ describe("Diagnostics Tests", () => {
 						{
 							severity: DiagnosticSeverity.DIAGNOSTIC_ERROR,
 							message: "File-level error",
+							range: {
+								start: { line: 0, character: 0 },
+								end: { line: 0, character: 10 },
+							},
 						},
 					],
 				},
@@ -248,7 +272,7 @@ describe("Diagnostics Tests", () => {
 
 			const result = await diagnosticsToProblemsString(diagnostics, severities)
 
-			expect(result).to.equal("src/file1.ts\n- [Error] Line : File-level error")
+			expect(result).to.equal("src/file1.ts\n- [Error] Line 1: File-level error")
 		})
 
 		it("should handle diagnostics with missing start property in range", async () => {

src/shared/proto-conversions/cline-message.ts

@@ -188,6 +188,15 @@ export function convertClineMessageToProto(message: AppClineMessage): ProtoCline
 					endIndex: message.conversationHistoryDeletedRange[1],
 				}
 			: undefined,
+		// Additional optional fields for specific ask/say types
+		sayTool: undefined,
+		sayBrowserAction: undefined,
+		browserActionResult: undefined,
+		askUseMcpServer: undefined,
+		planModeResponse: undefined,
+		askQuestion: undefined,
+		askNewTask: undefined,
+		apiReqInfo: undefined,
 	}
 
 	return protoMessage