Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accept poor-formatted POSTs #35

Open
LookItsJosh opened this issue Jun 5, 2020 · 2 comments
Open

Don't accept poor-formatted POSTs #35

LookItsJosh opened this issue Jun 5, 2020 · 2 comments

Comments

@LookItsJosh
Copy link

If the app sends a corrupt or manually edited POST with a non-base64 encoded string, it will crash after the backend returns those values. Rejecting non encoded strings ought to fix this issue and prevent additional potential API problems.

@ramnanib2
Copy link
Collaborator

can you post an example ? The back-end validates the report ensuring TCN report format is honored.

@LookItsJosh
Copy link
Author

A colleague brought it up to me, the client side issue is Co-Epi/app-android#204. It has all the details I have, but I can request more if needed.

Ideally, the frontend can handle an improper response without crashing, but the backend should try to catch improper requests before they are sent back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants