Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kotlin unit tests #17

Open
bleggett opened this issue Apr 17, 2020 · 3 comments
Open

Fix Kotlin unit tests #17

bleggett opened this issue Apr 17, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@bleggett
Copy link

All 6 of the unit tests are currently disabled because they are failing.

We should fix them and re-enable them.

@bleggett bleggett added the good first issue Good for newcomers label Apr 17, 2020
@ramnanib2
Copy link
Collaborator

ramnanib2 commented Apr 22, 2020

The reason they are failing is because they assume DynamoDB credentials and table set up on the dev box where they're running from. Using DynamoDBLocal library should remove that hard dependency and allow us to add better tests:

https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/DynamoDBLocal.html

@mihn
Copy link

mihn commented Apr 27, 2020

I can pick this up :)

@jmccance
Copy link

Looks like some work on this has been started here: #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants