Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The input pages for follow ups doesn't seem to be checking input for errors. #275

Open
sthomas313-gatech opened this issue Jun 17, 2020 · 6 comments
Milestone

Comments

@sthomas313-gatech
Copy link
Member

Describe the bug
NOTE: I am running on a simulator rather than a physical device.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'CoEpi' App
  2. Click on 'Symptom Report'
  3. Click on any of the symptoms to prompt a followup.
  4. Enter non-numeric values.
  5. Click "Next" and it should go through without error checking.

Expected behavior
It should either return error to user on screen and explain input was invalid or something else of that nature.

Screenshots
Simulator Screen Shot - iPhone SE (2nd generation) - 2020-06-17 at 09 57 00
Simulator Screen Shot - iPhone SE (2nd generation) - 2020-06-17 at 09 56 15

@ivnsch
Copy link
Collaborator

ivnsch commented Jun 17, 2020

For completeness, how did you enter the text (at least the keyboard should be numeric)?
@astewart43-gtri #191

@ivnsch
Copy link
Collaborator

ivnsch commented Jun 17, 2020

Ah, simulator. You probably entered them using the computer's keyboard. This is a corner case. Not sure whether it should be prioritized for 0.3. @danamlewis

For the record, the invalid input is discarded (i.e. handled as if the user didn't enter anything) and shows an error message in the logs.

@sthomas313-gatech
Copy link
Member Author

Yes the computer keyboard allows me to enter anything, including emojis into the field. But yes, I understand this a corner case.

@sthomas313-gatech
Copy link
Member Author

While checking out accessibility elements, one of the things I found was : Settings > Accessibility > Keyboards, tap Full Keyboard Access, then turn on Full Keyboard Access. This will allow for people who is external keyboards to have additional inputs like I had on the simulator.

@ivnsch
Copy link
Collaborator

ivnsch commented Jun 25, 2020

We definitely need to add validation. It's not something I personally would prioritize right now, though. Maybe as a refinement for 0.6 or so.

@sthomas313-gatech sthomas313-gatech removed their assignment Jun 29, 2020
@ivnsch
Copy link
Collaborator

ivnsch commented Jun 29, 2020

I'll set assign a hypothetic 0.6 milestone to this, just to signalize that we want to solve it "at some point in the future".

@ivnsch ivnsch added this to the 0.6 milestone Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants