-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The input pages for follow ups doesn't seem to be checking input for errors. #275
Comments
For completeness, how did you enter the text (at least the keyboard should be numeric)? |
Ah, simulator. You probably entered them using the computer's keyboard. This is a corner case. Not sure whether it should be prioritized for 0.3. @danamlewis For the record, the invalid input is discarded (i.e. handled as if the user didn't enter anything) and shows an error message in the logs. |
Yes the computer keyboard allows me to enter anything, including emojis into the field. But yes, I understand this a corner case. |
While checking out accessibility elements, one of the things I found was : Settings > Accessibility > Keyboards, tap Full Keyboard Access, then turn on Full Keyboard Access. This will allow for people who is external keyboards to have additional inputs like I had on the simulator. |
We definitely need to add validation. It's not something I personally would prioritize right now, though. Maybe as a refinement for 0.6 or so. |
I'll set assign a hypothetic 0.6 milestone to this, just to signalize that we want to solve it "at some point in the future". |
Describe the bug
NOTE: I am running on a simulator rather than a physical device.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should either return error to user on screen and explain input was invalid or something else of that nature.
Screenshots
The text was updated successfully, but these errors were encountered: