Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show CI status in PRs #217

Open
ivnsch opened this issue Jun 4, 2020 · 4 comments
Open

Show CI status in PRs #217

ivnsch opened this issue Jun 4, 2020 · 4 comments
Labels
good first issue Good for newcomers
Milestone
0.4

Comments

@ivnsch
Copy link
Collaborator

ivnsch commented Jun 4, 2020 •
edited
Loading

Setup continuous integration to show status (compiling, tests) in PRs.
@ivnsch ivnsch added this to the 0.4 milestone Jun 4, 2020
@ivnsch
Copy link
Collaborator Author

ivnsch commented Jun 17, 2020

Example (this is Bitrise. AppCenter should have something similar?)

Screen Shot 2020-06-18 at 00 10 54

@astewart43-gtri
Copy link
Contributor

I may be reading this incorrectly, but based on this documentation I would assume the repo owners would need install the App Center GitHub app.

@ivnsch
Copy link
Collaborator Author

ivnsch commented Jun 17, 2020 •
edited
Loading

AFAIK it's installed, and it what's updating the build status badge on the readme. The task here would be to get it working (in cooperation with the owners) for the PRs CI.

The problem right now actually is that we don't have an account to use AppCenter, but this should be solved this week.

Edit: The badge actually doesn't come from the app integration, but it's installed in this repo.

@ivnsch
Copy link
Collaborator Author

ivnsch commented Jun 26, 2020

Note that we don't need instrumented tests. Only linting and Unit Tests.

@astewart43-gtri astewart43-gtri removed their assignment Jul 1, 2020
@ivnsch ivnsch added the good first issue Good for newcomers label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@ivnsch @astewart43-gtri