Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request address is returning unitId #320

Open
miqmago opened this issue Dec 24, 2022 · 1 comment
Open

Request address is returning unitId #320

miqmago opened this issue Dec 24, 2022 · 1 comment
Assignees
Labels

Comments

@miqmago
Copy link

miqmago commented Dec 24, 2022

return this.unitId

  get address () {
    return this.unitId
  }

  get slaveId () {
    return this.unitId
  }

I'm not sure if this is the correct value, shouldn't it return return this._body._start || this._body._address?
In case of slaveId I'm not sure of the value that should be returned...

@stefanpoeter
Copy link
Member

Yes, that is probably a bug :-)

@stefanpoeter stefanpoeter self-assigned this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants