Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce API documentation #160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enforce API documentation #160

wants to merge 1 commit into from

Conversation

pravic
Copy link
Contributor

@pravic pravic commented Sep 26, 2024

Summary

Currently almost nobody documents added functions which is not good for the users of this library - but the API must have documentation.

Let's warn about missing docs (deny would be even better).

src/lib.rs Outdated Show resolved Hide resolved
Currently almost nobody documents added functions which is not good
for the users of this library - but the API must have documentation.

Let's warn about missing docs (deny would be even better).
@pravic
Copy link
Contributor Author

pravic commented Dec 4, 2024

Guys? @slvrtrn @loyd

More and more PRs are merged, but nobody cares about maintaining the API documentation.

@loyd
Copy link
Collaborator

loyd commented Dec 5, 2024

More and more PRs are merged, but nobody cares about maintaining the API documentation.

I agree; we need to force the creation of documentation for all new extensions.
But we cannot just merge this PR and break CI. This check must be enabled, but only after adding all missing docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants