Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffusive fluxes and advective fluxes have different units #3755

Open
simone-silvestri opened this issue Aug 31, 2024 · 1 comment
Open

Diffusive fluxes and advective fluxes have different units #3755

simone-silvestri opened this issue Aug 31, 2024 · 1 comment

Comments

@simone-silvestri
Copy link
Collaborator

simone-silvestri commented Aug 31, 2024

At the moment the divergence of the diffusive fluxes is calculated as

@inline function ∇_dot_qᶜ(i, j, k, grid, closure::AbstractTurbulenceClosure, diffusivities, tracer_index, args...)
    disc = time_discretization(closure)
    return 1/Vᶜᶜᶜ(i, j, k, grid) * (δxᶜᵃᵃ(i, j, k, grid, Ax_qᶠᶜᶜ, _diffusive_flux_x, disc, closure, diffusivities, tracer_index, args...) +
                                    δyᵃᶜᵃ(i, j, k, grid, Ay_qᶜᶠᶜ, _diffusive_flux_y, disc, closure, diffusivities, tracer_index, args...) +
                                    δzᵃᵃᶜ(i, j, k, grid, Az_qᶜᶜᶠ, _diffusive_flux_z, disc, closure, diffusivities, tracer_index, args...))
end

with _diffusive_flux equal to $\kappa \partial c$ so it has the units of $[c] m / s$
but the divergence of the advective fluxes is

@inline function div_Uc(i, j, k, grid, advection, U, c)
    return 1/Vᶜᶜᶜ(i, j, k, grid) * (δxᶜᵃᵃ(i, j, k, grid, _advective_tracer_flux_x, advection, U.u, c) +
                                    δyᵃᶜᵃ(i, j, k, grid, _advective_tracer_flux_y, advection, U.v, c) +
                                    δzᵃᵃᶜ(i, j, k, grid, _advective_tracer_flux_z, advection, U.w, c))

with _advective_tracer_flux equal to $A\cdot u c$ with units of $[c] m^3 / s$

I propose we use the same convention for diffusive and advective fluxes.

@simone-silvestri simone-silvestri changed the title Viscous fluxes and advective fluxes have different units Diffusive fluxes and advective fluxes have different units Aug 31, 2024
@glwagner
Copy link
Member

True, perhaps we should modify advective_*_flux so that it doesn't include the areas, is that your suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants