Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level for doctesting with warnings #3707

Closed
wants to merge 2 commits into from

Conversation

glwagner
Copy link
Member

Closes #3705

sigh

@navidcy navidcy self-requested a review August 14, 2024 04:13
Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks for dealing with the annoying doctests....

@navidcy navidcy added the testing 🧪 Tests get priority in case of emergency evacuation label Aug 14, 2024
@navidcy
Copy link
Collaborator

navidcy commented Aug 14, 2024

hey you need to use

DocTestSetup = quote
    function foo(x)
        return x^2
    end
end

@glwagner
Copy link
Member Author

hey you need to use

DocTestSetup = quote
    function foo(x)
        return x^2
    end
end

I wanted to avoid activating it globally

@glwagner
Copy link
Member Author

Feel free to try to get it to work

@navidcy
Copy link
Collaborator

navidcy commented Aug 14, 2024

OK I'll try later!

@navidcy
Copy link
Collaborator

navidcy commented Aug 14, 2024

but FYI:

@setup example1

is used to configure @examples, not doctests; that's why it didn't work.

On a different note, using # hide notation won't work in the sense the code will run but it won't be hidden -- that's syntax from Literate.jl package and we are not liberating the docs; only examples.jl

@glwagner
Copy link
Member Author

Didn't work

@glwagner glwagner closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert code blocks documenting ImmersedBoundaryCondition to doctests
2 participants