Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names are not appended to snippets #77153

Open
Uwuewsky opened this issue Oct 19, 2024 · 0 comments
Open

Names are not appended to snippets #77153

Uwuewsky opened this issue Oct 19, 2024 · 0 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@Uwuewsky
Copy link
Contributor

Describe the bug

The comment states that these snippets will have a name added to the end:

"category": "<kill_npc>",
"//": "Friendly NPC complaint that they're attacking a particular hostile NPC. The code always appends the name of NPC, so you get 'I can take on Tonza'.",

Yet these snippets appear without names in NPC shouts.

Category <kill_npc> affected.
I don't know about <kill_npc_h> or <movement_noise_warning>, NPCs have been kind of quiet lately, I can't get them to say these snippets. <monster_warning> works as expected.

Attach save file

N/A

Steps to reproduce

  1. Spawn an NPC, take them into your team.
  2. Spawn another NPC, make them hostile.
  3. Repeat step 2 until the allied NPC shouts out that they will kill.

Expected behavior

  1. Fix a bug so that names are appended to snippets.
  2. Or fix the comment and snippets. It makes sense for NPCs not to shout out names in their battle cries.

Screenshots

s1

s2

snip1

Versions and configuration

build type: linux-tiles-x64
build number: 2024-10-09-1005
commit sha: 4fc2b6b
commit url: 4fc2b6b

(No, #76102 has nothing to do with it, this behavior was there before the merge, screenshots were taken in the version before it)

Additional context

No response

@Uwuewsky Uwuewsky added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

1 participant