Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Addon API documentation : Add test environment details #337

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

allemas
Copy link
Contributor

@allemas allemas commented Jul 16, 2024

Describe your PR

In clever's internal functioning, if there is no test environment, the addon doesn't work properly.

I've added a note to this subject in the document, specifying that if there is no test environment, the same thing must be entered as for “prod”.

@allemas allemas temporarily deployed to PR review apps July 16, 2024 12:32 — with GitHub Actions Inactive
Copy link

Deployment has finished 👁️👄👁️ Your app is available here

@juliamrch
Copy link
Collaborator

Hi @allemas, you can already check the editorial linter warnings related to this file to modify it.

@juliamrch juliamrch added documentation Improvements or additions to documentation waiting Waiting from fixes or tests by submitter labels Jul 23, 2024
@juliamrch juliamrch requested a review from miton18 August 13, 2024 15:25
Copy link

github-actions bot commented Sep 3, 2024

🚀 You updated your review app. Check it here

Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @allemas,

I added two suggestions and another sentence needs to be clearer.

@@ -66,9 +66,10 @@ Fields

* `api/production/sso_url` - The production endpoint for single sign-on.

* `api/test/base_url` - The test endpoint on which Clever Cloud sends actions requests. Used to test your service when you create an add-on provider. After the add-on creation,`api/production/base_url` is used.
* `api/test/base_url` - The test endpoint on which Clever Cloud sends actions requests. Used to test your service when you create an add-on provider. After the add-on creation,`api/production/base_url` is used. If you're **not using** a test environment, set the same value as `api/production/base_url`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"After the add-on creation,api/production/base_url is used" : by who or by what @allemas ?

Suggested change
* `api/test/base_url` - The test endpoint on which Clever Cloud sends actions requests. Used to test your service when you create an add-on provider. After the add-on creation,`api/production/base_url` is used. If you're **not using** a test environment, set the same value as `api/production/base_url`.
* `api/test/base_url` - The test endpoint on which Clever Cloud sends actions requests. Use it to test your service when you create an add-on provider. After the add-on creation,`api/production/base_url` is used. If you're **not using** a test environment, set the same value as `api/production/base_url`.


* `api/test/sso_url` - The test endpoint for single sign-on. Used to test your service when you create an add-on provider. After that, the `api/production/sso_url` is used.
* `api/test/sso_url` - The test endpoint for single sign-on. Used to test your service when you create an add-on provider. After that, the `api/production/sso_url` is used. If you're **not using** a test environment, set the same value as
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the api/production/sso_url is used": idem

Suggested change
* `api/test/sso_url` - The test endpoint for single sign-on. Used to test your service when you create an add-on provider. After that, the `api/production/sso_url` is used. If you're **not using** a test environment, set the same value as
* `api/test/sso_url` - The test endpoint for single sign-on. Use it to test your service when you create an add-on provider. After that, the `api/production/sso_url` is used. If you're **not using** a test environment, set the same value as

Copy link

github-actions bot commented Sep 6, 2024

🚀 You updated your review app. Check it here

@juliamrch juliamrch marked this pull request as draft September 6, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation waiting Waiting from fixes or tests by submitter
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants