Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Update DataLoader to include cloud masks we create #1

Open
mcecil opened this issue Jun 13, 2023 · 4 comments
Open

1. Update DataLoader to include cloud masks we create #1

mcecil opened this issue Jun 13, 2023 · 4 comments

Comments

@mcecil
Copy link
Contributor

mcecil commented Jun 13, 2023

No description provided.

@mcecil
Copy link
Contributor Author

mcecil commented Jun 15, 2023

add new class similar to HLSDataset to read in mask data. Then duplicate mask for each band.

  • remove normalization
  • remove random cropping and cloud masknig (both for our new HLSDataset and MaskDataset)

@mcecil
Copy link
Contributor Author

mcecil commented Jun 26, 2023

I've added changes to create a MaskDataset object.

  • Normalization appears to be done regardless of what is specified. There is a line of code in getitem of HLSDataset

channels = (channels - self.mean) / self.std

  • this line is run regardless of how normalization is set. I've commented this out for the MaskDataset object. I am confused how this works for HLSDataset. Are we normalizing twice?
  • I've also commented code for rescaling reflectance values, which we don't want for the mask.
  • Do we need to pair images between the imagery and mask datasets? I am guessing yes. Train and val chips are defined in json file. If we treat the HLS and Mask datasets as separate objects, we are assuming that we have the same .tif files listed for HLS and mask datasets. In other words, the same # of chips, in the same order.
  • Alternatively, we could create one HLS + Mask imagery object that contains 5 bands (4 HLS + mask), and then we can have functions to slice off the HLS part and the Mask part. I think this could be cleaner for keeping track of images.
    @HamedAlemo

@mcecil
Copy link
Contributor Author

mcecil commented Jun 26, 2023

I still need to duplicate mask for each band.

@mcecil
Copy link
Contributor Author

mcecil commented Jun 26, 2023

I added mask duplication. Currently hard-coded to repeat 4 times. We should decide if we want to keep separate HLS and Mask objects or make 1 combined object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant