Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking group assignment against ddbst utility - distinguishing "CH2" from "CY-CH2" #1

Open
viniviena opened this issue May 31, 2023 · 2 comments

Comments

@viniviena
Copy link

Hello all. I am benchmarking the program for complicated molecules and comparing with ddbst group assingment utility. The assignment seems to be on point. There is only one assignment that seems to be different as below:

  1. GCI Identifier:
    get_groups_from_smiles("CC(=O)OCC1CCC(C23C14C2CC(C3)C4(C)C)(C)C", UNIFACGroups) produces:

("CC(=O)OCC1CCC(C23C14C2CC(C3)C4(C)C)(C)C", ["CH3" => 4, "CH3COO" => 1, "CY-CH2" => 4, "CY-C" => 4, "CY-CH" => 3, "CH2" => 1])

  1. using ddbst utility I've got:
    ["CH3" => 4, "CH2" => 5, "CH" => 3, "C" => 4, "CH3COO" => 1 ])

*It seems it is distinguishing "CY-CH2" from "CH2". What is the difference between these two groups? Does it affect the activity coefficient calculation?

@longemen3000
Copy link
Member

at first glance CY seems to be a shortcut for Cycle? if that is the case, then it seems to be correct ?
image

@viniviena
Copy link
Author

Oh. Thanks for the clarification. That's seems to be the case. The current algorithm is distinguishing cyclic CH2 from CH2. I don't know if they are separate groups in UNIFAC, but it's nice having an algorithm that distinguish both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants