Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parser city-names.properties #34

Open
mattyschell opened this issue Jan 24, 2020 · 1 comment
Open

Update parser city-names.properties #34

mattyschell opened this issue Jan 24, 2020 · 1 comment

Comments

@mattyschell
Copy link
Member

@mlipper In order to put some constraints on this update can you say a little about the intent of city-names.properties?

Reverse-engineering from what's listed there I see "city names" in the sense that these names are recognized by the United States Post Office as preferred or alternative USPS city names. Most people would define Jackson Heights, for example, as a neighborhood name in the Borough of Queens.

Do you have any wish to add more neighborhood names to this list?

UPPER\ WEST\ SIDE=MANHATTAN

Or stick with USPS city name alternatives only?

@mlipper
Copy link
Member

mlipper commented Feb 10, 2020

The initial purpose of these properties was to allow the lexer to recognize tokens given for Queen's "city" names as belonging to that borough. Because the USPS officially recognized such names, it is common practice for Queens residents to submit, e.g., "Flushing" instead of "Queens" when prompted for a borough.

However, the existence of entries which resolve to "Manhattan", e.g., "NYC", indicates that at some point, I expanded the original use case to include common aliases for Manhattan. Sooo, in light of that, would you kindly consider the following?

Please, add any updated USPS official/preferred names not present and also (if available) common neighborhood names and their respective boroughs. When doing so, please append to the existing file rather than insert the names among those already present (which are in alphanumeric order).

Thanks!
Matt L.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants