Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linutil doesn't handle old version of Alacrity #364

Open
radek-chramosil opened this issue Sep 12, 2024 · 9 comments
Open

linutil doesn't handle old version of Alacrity #364

radek-chramosil opened this issue Sep 12, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@radek-chramosil
Copy link

radek-chramosil commented Sep 12, 2024

Describe the bug

I run this OS:
Linux pop-os 6.9.3-76060903-generic

Pop OS only has Alacrity 0.12.2 available, which doesn't support Toml files (supported from v1.0.0 - I think).

$ alacritty --version
alacritty 0.12.2

Hence, these lines of code are useless for my OS setup.

mkdir -p "${HOME}/.config/alacritty/"
wget -O "${HOME}/.config/alacritty/alacritty.toml" "https://github.com/ChrisTitusTech/dwm-titus/raw/main/config/alacritty/alacritty.toml"
wget -O "${HOME}/.config/alacritty/nordic.toml" "https://github.com/ChrisTitusTech/dwm-titus/raw/main/config/alacritty/nordic.toml"

To Reproduce

Steps to reproduce the behavior:

  1. Install a current version of Pop OS (some VM/container is enough)
  2. Check the version of Alacrity

Expected behavior

I was expecting that the bash script would apply your default settings, however, I didn't remember I run on old Alacrity.

Screenshots

N/A

Additional context

N/A

@radek-chramosil radek-chramosil added the bug Something isn't working label Sep 12, 2024
@adamperkowski
Copy link
Contributor

Pop OS only has Alacrity 0.12.2 available, which doesn't support Toml files (supported from v1.0.0 - I think).

It's v0.13.0. I'll open a PR.

@RazoBeckett
Copy link
Contributor

I have created two PRs: one on Dwm-titus #66 and another, #369, on this repository, which closes this issue. Instead of not supporting older versions, these changes allow users with newer versions of Alacritty to migrate from the old YAML format to TOML. The PRs have been created to fulfill that purpose.

@adamperkowski
Copy link
Contributor

@RazoBeckett You shouldn't just yoink the code from my PR and create yours. Doesn't work that way.
Besides, the script would need an update if #66 is merged.

@RazoBeckett
Copy link
Contributor

RazoBeckett commented Sep 13, 2024

@adamperkowski , Yes, script also has a update check #369, and about code my condition is written by one of @ChrisTitusTech beloved LLM called 'ChatGPT' i didn't looked into PRs for that issue i don't care if @ChrisTitusTech Rejects my PRs because i am here to just help him maintain the projects not for Getting my PRs merged.

@RazoBeckett
Copy link
Contributor

And hell nah you just copied my shit and calling its yours, thank god its all git controlled i can show the timings of my commits you even copied my comment of 'using 'command' to avoid alias'

@adamperkowski
Copy link
Contributor

i didn't looked into PRs for that issue i don't care if ChrisTitusTech Rejects my PRs because i am here to just help him maintain the projects not for Getting my PRs merged.

You should probably check for duplicates before submitting anything. You can suggest changes to PRs on GitHub.

@RazoBeckett
Copy link
Contributor

i didn't looked into PRs for that issue i don't care if ChrisTitusTech Rejects my PRs because i am here to just help him maintain the projects not for Getting my PRs merged.

You should probably check for duplicates before submitting anything. You can suggest changes to PRs on GitHub.

as i said i don't care if he closes my PRs.

@adamperkowski
Copy link
Contributor

adamperkowski commented Sep 13, 2024

And hell nah you just copied my shit and calling its yours, thank god its all git controlled i can show the timings of my commits you even copied my comment of 'using 'command' to avoid alias'

I literally added you as a co-author. cdb6f3d, #369 (comment). Never called your comments "mine"

@RazoBeckett
Copy link
Contributor

😢 okay you know what sorry for being shitty as i said i don't care about he closing my PRs i will close the #369 one by myself .. @adamperkowski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants