Relay Guid Identifier Unable to convert type from Object to Guid
#7110
Comments
|
Thanks for the repro ... we will have a look at this. |
|
Is there any status on this? |
|
this is still an issue with 130 |
|
I ran into the same issue. I already start to dig into the problem and created a unittest which reproduces the problem. It seems that the ids are deserialized two times. I hope to fix this problem soon and will do a pr then. |
|
I created a branch which reproduces the problem https://github.com/ChilliCream/graphql-platform/tree/mha/7110-id-filter-bug. The problem seems to be that Member type is null in RelayIdFilterFieldExtensions. That's why a wrong Id serializer is created. So far I did not find the right spot where the Member should be set because my knowledge of the code is not good enough. I will try to find the solution but maybe somehow knows it right away. |
|
@michaelstaib I am sorry. I don't find the correct spot. Maybe the unittest and the text above helps you to find the bug. Give me a ping if there is anything I can do. |
|
After further investigation, I was able to resolve the issue, though I don't have enough context to be sure it won't cause issues elsewhere. It seems the problem lies in the if (serializer.ValueSerializer.IsSupported(runtimeType))
{
valueSerializer = serializer.ValueSerializer;
}
else if (valueSerializer is null)
{
valueSerializer = TryResolveSerializer(runtimeType);
}
if (valueSerializer is null)
{
throw SerializerMissing(typeName, rentedBuffer);
}
var value = ParseValue(valueSerializer, serializer.TypeName, span.Slice(delimiterIndex + delimiterOffset));
Clear(rentedBuffer);
return value;In this case, While this works for types like integers, it doesn't for GUIDs when using the new compressed format, which is enabled by default. When the compressed string is later processed to convert it to a GUID, it fails giving us the To fix this, I think we need to modify the @michaelstaib If this approach seems reasonable and you're not concerned about it causing any issues, I'm happy to submit a PR. |
|
This would not fix the issue just just put a workaround in because another component passes on the wrong type information. The issue is with filtering, and we have to fix it there. |
|
In filtering probably the runtime type is not set, as far as I can tell from this issue. |
|
@A360JMaxxgamer was on the right track. |
|
@michaelstaib I see. In that case, it looks like the public IFilterOperationFieldDescriptor Operation(int operationId)
{
var fieldDescriptor =
Operations.FirstOrDefault(t => t.Definition.Id == operationId);
if (fieldDescriptor is null)
{
fieldDescriptor = FilterOperationFieldDescriptor.New(
Context,
operationId,
Definition.Scope);
Operations.Add(fieldDescriptor);
}
return fieldDescriptor;
} |
|
I created a pr. It fixes the issue but it feels a bit hacky. I did not find a better solution. But I now understand the problem. before we tried to set the member data which was used to deserialize the value. Actually we could never use that or set that. The member type on the filterfieldoperation can be different for various inputs. The field type for e.g. "nin" on the schema is always IdFilterOperationNin therefore we can not determine the runtime type for a specific id when we complete that type. I tried to move the logic to the input parser. The input parser has a target type. So when the parser sees a formatter for ids it tries to pass the targetType to it. |
|
@A360JMaxxgamer I will have a look through the PR and then we see how we can make it work. |
Product
Hot Chocolate
Version
14.0.0-p.100
Link to minimal reproduction
https://github.com/PHILLIPS71/HC-7110
Steps to reproduce
I've previously used Guid identifiers in relay without any issues, though after upgrading to version 14 it doesn't seem to work anymore.
What is expected?
The relay identifiers can be converted into a GUID
What is actually happening?
Relevant log output
No response
Additional context
If you decode
TGlicmFyeTq+UuauxXXqSp5/h9rbTMR0it looks invalid (Library:RuJ�Lt)The text was updated successfully, but these errors were encountered: