Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subgraph/"supergraph" functions to AtomGraph #9

Open
rkurchin opened this issue Sep 14, 2020 · 0 comments
Open

add subgraph/"supergraph" functions to AtomGraph #9

rkurchin opened this issue Sep 14, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@rkurchin
Copy link
Member

It would be really cool to be able to filter based on feature values (for example, if the contextual features idea from this issue gets implemented, then we could for example take only the adsorbate atoms or only the surface atoms.

Would need to make sure to modify feature matrix and element list appropriately and also recompute laplacian, but this should be easy.

Similarly, would be cool to construct larger graphs (e.g. adsorbed species on a surface) by just inputting two smaller ones and specifying which edges need to be added (e.g. an edge from node X in graph 1 to node y in graph 2), though how to handle working out weights would need to be figured out...

@rkurchin rkurchin added the enhancement New feature or request label Sep 14, 2020
@rkurchin rkurchin self-assigned this Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant