Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make features unitful? #57

Open
rkurchin opened this issue Apr 19, 2021 · 3 comments
Open

make features unitful? #57

rkurchin opened this issue Apr 19, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@rkurchin
Copy link
Member

Really just a "nice to have" thing and not crucial at all...leaving here as a note to self, to be eventually categorized properly once I decide on a list of issue tags.
@thazhemadam
Copy link
Member

@rkurchin what exactly do you have in mind? Some details/examples might help.

@rkurchin
Copy link
Member Author

It's sort of in the general spirit of interpretability/readability of features. Just the idea of using Unitful.jl to attach units to all the quantities that get encoded. It wouldn't change anything about how the models work or anything.

@thazhemadam
Copy link
Member

thazhemadam commented Apr 21, 2021 •
edited
Loading

Hmm, I understand. Using a decorator for implementing this might be a clean solution imo.

@rkurchin rkurchin added the enhancement New feature or request label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rkurchin @thazhemadam