Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More options in graph-building #24

Open
rkurchin opened this issue Nov 9, 2020 · 0 comments
Open

More options in graph-building #24

rkurchin opened this issue Nov 9, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@rkurchin
Copy link
Member

rkurchin commented Nov 9, 2020

Currently we have the cgcnn.py option plus the Voronoi option. It would make sense to add an option to cut off by distance (e.g. nearest, second-nearest, etc. neighbors). Things to figure out here:

  • what's a reasonable "default" tolerance for counting neighbors as being in a set (e.g. all being nearest or second-nearest)? Once we set this we can ensure all their edge weights are the same which will be useful e.g. in DEQ stuff
  • would it make sense to implement a cutoff about distances to an atom's periodic images of itself? e.g. a "stop-adding-edges" condition once an atom has hit its own image? In a lot of cases (i.e. really large unit cells) you probably wouldn't actually want to go anywhere near this far, but for smaller ones I doubt you'd often want to go much past this...
@rkurchin rkurchin added the enhancement New feature or request label Nov 9, 2020
@rkurchin rkurchin self-assigned this Nov 9, 2020
@rkurchin rkurchin removed their assignment Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant