Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Flux as a dependency with OneHotArrays and bump AtomsBase compat #139

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

thazhemadam
Copy link
Member

No description provided.

@thazhemadam thazhemadam self-assigned this Nov 3, 2023
Replace Flux, which is a pretty big dependency, with the much
more lightweight and specialized OneHotArrays.
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #139 (dd04e5d) into main (632c884) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   85.18%   84.93%   -0.25%     
==========================================
  Files          11       11              
  Lines         162      166       +4     
==========================================
+ Hits          138      141       +3     
- Misses         24       25       +1     
Files Coverage Δ
src/codecs/onehotonecold.jl 82.97% <ø> (-1.47%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Member

@rkurchin rkurchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me...seems the documentation build is broken but there's no way this caused that, so I'm happy to merge!

@rkurchin rkurchin merged commit 11a1110 into main Nov 3, 2023
7 of 9 checks passed
@rkurchin rkurchin deleted the at/no-more-flux branch November 3, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants