Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move output_file_path to positional arguments in AtomGraph constructor from file #107

Open
rkurchin opened this issue Jul 19, 2021 · 0 comments
Labels
enhancement New feature or request priority feature to add or bug to fix soon!

Comments

@rkurchin
Copy link
Member

This should be really easy, I'm just busy with other stuff this second and don't want to forget.

Reason being, currently if we want to build and serialize a large number of graphs, they'd all have to be stored in memory and then serialized one by one, and you lose progress if something goes wrong (such as, for example, some graphs couldn't be built and then the script borks when it tries to serialize a missing object). if we make this change, then we can broadcast over output files and serialize a graph as it's being created, and we won't run into the problem I'm describing.

Is this informed by very specific experience today? Maayyyybe...

@rkurchin rkurchin added enhancement New feature or request priority feature to add or bug to fix soon! labels Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority feature to add or bug to fix soon!
Projects
None yet
Development

No branches or pull requests

1 participant