Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some blend functions cause corruption and freezes #158

Open
VisualEhrmanntraut opened this issue Sep 6, 2023 · 111 comments
Open

Some blend functions cause corruption and freezes #158

VisualEhrmanntraut opened this issue Sep 6, 2023 · 111 comments
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@VisualEhrmanntraut
Copy link
Member

VisualEhrmanntraut commented Sep 6, 2023

Software like Chrome and Sublime Text 4 can cause corruption and freezes.

To Reproduce

  1. Open software which uses dual source blend like Chrome and Sublime Text 4
  2. Observe

Expected behavior
The software working perfectly fine.

Screenshots
Screenshot 2023-09-06 at 10 45 40

@VisualEhrmanntraut VisualEhrmanntraut added the Bug Something isn't working label Sep 6, 2023
@VisualEhrmanntraut VisualEhrmanntraut added this to the Version 1.0.0 milestone Sep 6, 2023
@VisualEhrmanntraut VisualEhrmanntraut self-assigned this Sep 6, 2023
@VisualEhrmanntraut VisualEhrmanntraut pinned this issue Sep 6, 2023
@Xtuber14

This comment has been minimized.

@VisualEhrmanntraut
Copy link
Member Author

ANGLE is for WebGL. Nothing to do with Chrome itself glitching out.

@b00t0x

This comment has been minimized.

@DepsCian

This comment has been minimized.

@Xtuber14

This comment has been minimized.

@jalavoui

This comment has been minimized.

@Xtuber14

This comment has been minimized.

@jalavoui

This comment has been minimized.

@b00t0x

This comment has been minimized.

@shenfu1991

This comment has been minimized.

@VisualEhrmanntraut

This comment has been minimized.

@jalavoui

This comment has been minimized.

@VisualEhrmanntraut
Copy link
Member Author

Talking about that workaround... I just realised something:
With the VTable wrap hack the team ex-member came up with, if the called function inside the wrap calls another virtual function in the this pointer, then the wrong function gets called

@jalavoui

This comment was marked as spam.

@VisualEhrmanntraut
Copy link
Member Author

(The VTable hack has to do with HWAlignManager used inside it for calculations)

@alvindimas05

This comment has been minimized.

@truongvantuan

This comment has been minimized.

@alvindimas05

This comment has been minimized.

@revogabe
Copy link

@VisualEhrmanntraut Do you have any predictions if we can have any solution for chrome-based browsers natively in the future?

@VisualEhrmanntraut
Copy link
Member Author

New prediction available: No prediction available.

@alvindimas05

This comment was marked as off-topic.

@txrm
Copy link

txrm commented Oct 4, 2023

DOSBOX's OpenGL freezes the system immediately, looking into what triggers it since it's a fast and reliable crash.

Config field is output = surface | overlay | opengl | openglnb | ddraw

@VisualEhrmanntraut
Copy link
Member Author

VisualEhrmanntraut commented Nov 11, 2023

Chrome seems to die due to a command sent by libGLES2. Relevant log attached. (This is an Electron app, therefore uses Chromium)
YouTube_Music_Helper_GPU_2023-10-28-113038_MacBook-Pro.crash.txt

@VisualEhrmanntraut
Copy link
Member Author

VisualEhrmanntraut commented Nov 11, 2023

Also I found that in AMDRadeonX5000GLDriver, function _gfx9_HwInfoInitData and _amdUbm_HWL_Init, that the device family is hardcoded instead of being read from the accelerator.

@VisualEhrmanntraut
Copy link
Member Author

I never committed the changes though. You likely downloaded Sublime Text 3, which only does software rendering.

@murat-cevik
Copy link

murat-cevik commented Jun 21, 2024

I never committed the changes though. You likely downloaded Sublime Text 3, which only does software rendering.

Yes, it is 3.2.2 . and it didn't work before your latest fix.

@VisualEhrmanntraut
Copy link
Member Author

Interesting.

@kyvaith
Copy link

kyvaith commented Jun 27, 2024

I would hate to spoil your peace of mind @VisualEhrmanntraut, but do you perhaps have an assumed date for pushing the latest changes you did to the repository? I would be very grateful for this 😉

@VisualEhrmanntraut
Copy link
Member Author

These were Catalina-only tests made to find the reason for the crashes rather than a fix. There is no fix available, neither is a fix easy due to the design of Lilu. I am planning to make a Lilu replacement before I try to actually fix it.

@kyvaith
Copy link

kyvaith commented Jun 27, 2024

Oh, I thought Chrome would eventually work on Sonoma. I understand now that it takes more time and it's impossible to predict if and when you'll be able to solve the problem. Thank you.

@VisualEhrmanntraut
Copy link
Member Author

The cause seems to be multiple issues at once unfortunately. It seems to be that I'll have to also remove that last bit that I currently steal from the navi drivers to fix the issue in addition to fixing the user-space code. This is going to take a looot of time and effort...

@AlfCraft07
Copy link
Member

For me, Minecraft works just fine in Sequoia, even better than Windows.

@VisualEhrmanntraut
Copy link
Member Author

I've just received some very crucial data. On a person's system, the screen corruption magically reverted. This reinforces my thoughts on the issue, and I think getting rid of what I mentioned previously will fix it!

@VisualEhrmanntraut
Copy link
Member Author

it no worky

IMAGE 2024-06-28 22:19:21

@phpete1
Copy link

phpete1 commented Jun 28, 2024

it no worky

IMAGE 2024-06-28 22:19:21

Have you tried switching it off and on again?

@phpete1
Copy link

phpete1 commented Jun 28, 2024

it no worky

IMAGE 2024-06-28 22:19:21

In all seriousness, can't wait to see a fix for this, hopefully

@AlfCraft07
Copy link
Member

My pc with Minecraft Java (that uses OpenGL) doesn’t do that; the game runs even smoother than in Windows

@VisualEhrmanntraut
Copy link
Member Author

VisualEhrmanntraut commented Jun 28, 2024

This is Sublime Text 4.

@AlfCraft07
Copy link
Member

AlfCraft07 commented Jun 28, 2024

Ok. So it happens on Chrome, and is there any other app that can make it happen?

@ChitoKim
Copy link

League of Legends client(also opengl) used to crack like shit before. As I use the latest nightly kext it was fixed.

@JuniorHerakuresu
Copy link

League of Legends client(also opengl) used to crack like shit before. As I use the latest nightly kext it was fixed.

It glitches for me with nightly but a "bit" less than other times, but still annoying

@divasgt
Copy link

divasgt commented Jul 7, 2024

Ok. So it happens on Chrome, and is there any other app that can make it happen?

it happens when opening canva.com on firefox, and on chromium based browsers and apps i have to turn off graphics acceleration then they give no issue but then they uses high cpu and makes my laptop hotter

@techmare
Copy link
Member

techmare commented Jul 7, 2024

@divasgt Yes same here

@aidanbae123
Copy link

I use a site called notion for my studies and it used to crash any chromium or even firebox browser when simply opening the site. I installed the most recent nightly build and it no longer crashes my browser. However, the standalone app still causes severe graphical glitches and crashes my entire system if not closed in time. Either way, glad to see good progress.

@aidanbae123
Copy link

Also one thing I notices just now is that discord now seems to be crashing with slight graphical glitches which eventually becomes a blank grey tab. Not sure if this is the same issue but it was working fine before.

@pokewizardSAM
Copy link

Also one thing I notices just now is that discord now seems to be crashing with slight graphical glitches which eventually becomes a blank grey tab. Not sure if this is the same issue but it was working fine before.

from the last update or past 3-4 days mine does that too.

@aidanbae123
Copy link

yeah, I double checked by opening discord on arc (chromium-based) and it seems to be crashing as well. Works fine on safari though.

@diandiweb
Copy link

Programs that require hardware acceleration will crash

@aidanbae123
Copy link

Yeah I am very well aware of that, but my point was it wasn't crashing before

@frezyn
Copy link

frezyn commented Jul 18, 2024

i have same problem, Some fix to that?

@ChefKissInc ChefKissInc locked and limited conversation to collaborators Jul 23, 2024
@VisualEhrmanntraut
Copy link
Member Author

VisualEhrmanntraut commented Aug 25, 2024

We have found what causes the corruption; it's dual source blend. Switching ANGLE to OpenGL and ANGLE feature flags to disableBlendFuncExtended fixes the corruption. Sublime Text also uses this feature.
EDIT: Not always. It seems to be blending functions in general that are problematic.

@VisualEhrmanntraut VisualEhrmanntraut changed the title Advanced OpenGL apps may cause graphical glitches and/or GPU hangs Dual source blend causes corruption and freezes Aug 25, 2024
@VisualEhrmanntraut VisualEhrmanntraut changed the title Dual source blend causes corruption and freezes Some blend functions cause corruption and freezes Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests