fb/new-issue-workflow-part1 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- concrete types from class to sealed records - delete redundant interfaces
Reflecting that facilities are not trade-specific anymore
(and make consumables items a sub-type of ConsumablesIssue instead)
In preparation for logic to only show facilities active for selected sphere
- Added DomainTermJsonConverter in JsonHelper for new AvailableFacilities property - Limited facility selections to available ones in NewIssueFacilitySelection workflow
…onstitution This is necessary since it became a more complex record with a collection member, breaking down the default structural equality comparison for records, thereby breaking the reliance on HashSet for uniqueness in the ModelReader
This facilitates safe reflection over namespaces e.g. for trade-specific issue-type filtering in workflows
…wBridgesRepository
…active vs. reactive workflow launchers In the process, fix bridges repo and utility methods
…: generalised version for pro- and reactive launchers
…cher; rename/clean-up utils
…owBase, its only usage
…eral or not needed
dgor82
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging changes from feature branch