Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is printed but not returned #6

Open
meilof opened this issue Mar 6, 2019 · 1 comment
Open

Error is printed but not returned #6

meilof opened this issue Mar 6, 2019 · 1 comment

Comments

@meilof
Copy link
Collaborator

meilof commented Mar 6, 2019

I used the new version and tested again the case that I mentioned in my first comment. now during verification this is printed :
"Reading QAP vk: pysnark_vk_main
Verifying main (pysnark_vk_main) *** divisibility check failed
1"
isn't it supposed to print 0 (false) when the prover has executed a different code and as a result ,provided wrong proof and value?
why it is still printing 1(true)?

Originally posted by @Mahsa-Bastankhah in #4 (comment)

@meilof
Copy link
Collaborator Author

meilof commented Mar 6, 2019

I agree this is a bit confusing. Would be better to also return an error value in this case. This can be easily fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant