Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step4 Refactor #14

Open
5 tasks done
ChaminLee opened this issue Jan 26, 2022 · 0 comments
Open
5 tasks done

Step4 Refactor #14

ChaminLee opened this issue Jan 26, 2022 · 0 comments

Comments

@ChaminLee
Copy link
Owner

ChaminLee commented Jan 26, 2022 •
edited
Loading

  • 폴더 구조 변경
  • 접근 제어자 변경
  • 물리적인 코드 구조 잡기
  • 전체적인 코드 점검
  • 중복되는 코드 상속으로 대체하기
yim2627 added a commit that referenced this issue Jan 26, 2022
@yim2627
refactor: 전체 코드 접근제어자 및 구조 수정 #14
f923437
ChaminLee added a commit that referenced this issue Jan 26, 2022
@ChaminLee
refactor: ProductManageViewController에 등록/수정 공통 기능 구현 #14
18fb8d7 
- 상품 등록/수정 ViewController는 ProductManageViewController 상속
- AlertMessage 추가
- productRegisterManager내 판별 로직 추가
- productManageable 제거
yim2627 added a commit that referenced this issue Jan 26, 2022
@yim2627
chore: 파일 및 폴더 구조 변경 #14
df3d729 
- 화면별로 폴더 분리
yim2627 added a commit that referenced this issue Jan 26, 2022
@yim2627
refactor: productDetailImage 잘리지 않게 리사이징 #14
0a074ae
yim2627 added a commit that referenced this issue Jan 27, 2022
@yim2627
refactor: UserInformation -> VendorInformation 네이밍 수정 #14
aa37775
ChaminLee added a commit that referenced this issue Jan 27, 2022
@ChaminLee
refactor: ProductSecret -> ProductPassword 네이밍 변경 #14
c0b0c0a
yim2627 added a commit that referenced this issue Jan 27, 2022
@yim2627
refactor: api -> apiService 프로퍼티 네이밍 변경 #14
bc83fd9
ChaminLee added a commit that referenced this issue Jan 27, 2022
@ChaminLee
refactor: 불필요한 타입 명시 제거 #14
91400b0
yim2627 added a commit that referenced this issue Jan 27, 2022
@yim2627
refactor: 상품 삭제 및 비밀번호 조회 로직 변경 #14
a29e83e 
- checkValidInput -> checkValidReceivedProductDetail 네이밍 변경
ChaminLee added a commit that referenced this issue Jan 27, 2022
@ChaminLee
refactor: 조건문 들여쓰기 개선 #14
f9b201a
yim2627 added a commit that referenced this issue Jan 28, 2022
@yim2627
refactor: 타입, 메서드의 네이밍 변경 #14
bb9cf3a 
q
qa!
ChaminLee added a commit that referenced this issue Jan 28, 2022
@ChaminLee
refactor: ImageLoad 비동기로 변경 및 prefetch 구현 #14
ab25a4c 
- collectionView 스크롤 버벅임 해결
- prefetch에서 다음 페이지의 데이터를 불러오도록 구현
- cell 높이 고정적으로 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChaminLee