Skip to content
This repository has been archived by the owner on Dec 6, 2019. It is now read-only.

ci(all): upgrade to babel 7 and typescript #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci(all): upgrade to babel 7 and typescript #7

wants to merge 1 commit into from

Conversation

felixwu-s2
Copy link

@felixwu-s2 felixwu-s2 commented Oct 6, 2019 •
edited
Loading

it's me felix on another GH account lol - lib output is same as before, tests pass

skatcat31
skatcat31 approved these changes Oct 6, 2019
View reviewed changes
Copy link

@skatcat31 skatcat31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotta love TS

Chalarangelo
Chalarangelo suggested changes Oct 8, 2019
View reviewed changes
Copy link
Owner

@Chalarangelo Chalarangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am strongly against moving to typescript. It doesn't add anything of value for the most part and it only makes our CI pipeline heavier - this concerns me due to the limitations of CI free tiers.

I think we should only update babel or nothing at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Chalarangelo Chalarangelo Chalarangelo requested changes

@skatcat31 skatcat31 skatcat31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixwu-s2 @Chalarangelo @skatcat31