WIP problem with secrets.token for private repo - debugging

Cardinal-Cryptography · Dec 7, 2024 · 5fcbea5 · 5fcbea5
1 parent 7e6ae26
commit 5fcbea5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/.github/workflows/_build-aleph-node.yml b/.github/workflows/_build-aleph-node.yml
@@ -29,7 +29,7 @@ on:
         description: 'Personal access token (PAT) used to fetch the repository.'
         type: string
         required: false
-        default: ''
+        default: ${{ github.token }}
     outputs:
       artifact-name-binary:
         description: 'Name of artifact aleph-node binary'

diff --git a/.github/workflows/nightly-normal-session-e2e-tests.yml b/.github/workflows/nightly-normal-session-e2e-tests.yml
@@ -40,17 +40,6 @@ jobs:
       # yamllint disable-line rule:line-length
       artifact-aleph-node-image: ${{ needs.build-production-aleph-node.outputs.artifact-name-image }}
 
-  build-aleph-node-with-network-flooding-test:
-    needs: [check-vars-and-secrets]
-    name: Build aleph-node with flooding routines for both sync-network and alephbft-network
-    uses: ./.github/workflows/_build-aleph-node.yml
-    with:
-      ref: main
-      repository: Cardinal-Cryptography/aleph-node-flooder
-      production: false
-      additional-flags: "--features network_flooding_test"
-      token: ${{ secrets.CI_GH_TOKEN }}
-
   build-chain-bootstrapper-production:
     name: Build chain-bootstrapper
     uses: ./.github/workflows/_build-chain-bootstrapper.yml
@@ -328,15 +317,23 @@ jobs:
             --testcase test_major_sync
 
   run-network-flooding-test:
-    secrets: inherit
     needs:
+      - check-vars-and-secrets
       - build-production-aleph-node
-      - build-aleph-node-with-network-flooding-test
       - build-aleph-e2e-client-image
       - build-chain-bootstrapper-production
     name: Run network flooding test
     runs-on: ubuntu-20.04
     steps:
+      - name: Build aleph-node with flooding routines for both sync-network and AlephBFT network
+        uses: ./.github/workflows/_build-aleph-node.yml
+        with:
+          ref: main
+          repository: Cardinal-Cryptography/aleph-node-flooder
+          production: false
+          additional-flags: "--features network_flooding_test"
+          token: ${{ secrets.CI_GH_TOKEN }}
+
       - name: Checkout source code
         uses: actions/checkout@v4