Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract case charges outside of modal component #93

Open
2 tasks
nikuzejl opened this issue Feb 17, 2022 · 2 comments
Open
2 tasks

Extract case charges outside of modal component #93

nikuzejl opened this issue Feb 17, 2022 · 2 comments
Assignees
@nikuzejl
Labels
ms-cohort-claimed stale

Comments

@nikuzejl
Copy link
Contributor

nikuzejl commented Feb 17, 2022 •
edited
Loading

Background on the problem the feature will solve/improved user experience

The complete list of charges is currently in the modal component. By extracting it out, we can reduce coupling.

Describe the solution you'd like

Extract charges from outside the modal component

Tasks

  • Extract charges outside the modal component
  • Add unit tests

Acceptance Criteria

  • Be able to submit a new case with a charge selected
  • The charges filter and selector still work
@nikuzejl nikuzejl self-assigned this Feb 17, 2022
@github-actions
Copy link

Thank you so much for contributing to our work!

@chenhuyr chenhuyr mentioned this issue Feb 17, 2022
Open
5 tasks
@nikuzejl nikuzejl changed the title Extract case charges outside of model component Extract case charges outside of modal component Feb 17, 2022
nikuzejl added a commit to nikuzejl/Open-Sentencing-UI that referenced this issue Feb 18, 2022
@nikuzejl
issue Call-for-Code-for-Racial-Justice#93
64fe2a0
nikuzejl added a commit to nikuzejl/Open-Sentencing-UI that referenced this issue Feb 18, 2022
@nikuzejl
Extract case charges outside of modal component Call-for-Code-for-Rac…
f9e469f 
…ial-Justice#93
nikuzejl added a commit to nikuzejl/Open-Sentencing-UI that referenced this issue Mar 4, 2022
@nikuzejl
Extract case charges outside of modal component Call-for-Code-for-Rac…
da4f053 
…ial-Justice#93
nikuzejl added a commit to nikuzejl/Open-Sentencing-UI that referenced this issue Mar 4, 2022
@nikuzejl
Extract case charges outside of modal component Call-for-Code-for-Rac…
58761ab 
…ial-Justice#93
upkarlidder pushed a commit that referenced this issue Mar 8, 2022
Merge pull request #95 from nikuzejl/main
37c3392 
Extract case charges outside of modal component #93
@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikuzejl nikuzejl

Labels
ms-cohort-claimed stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikuzejl