Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract credentials into a .env file #64

Open
upkarlidder opened this issue Sep 17, 2021 · 3 comments
Open

Extract credentials into a .env file #64

upkarlidder opened this issue Sep 17, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed stale

Comments

@upkarlidder
Copy link
Member

upkarlidder commented Sep 17, 2021

Background on the problem the feature will solve/improved user experience

The credentials are coded in the src file.

https://github.com/Call-for-Code-for-Racial-Justice/Open-Sentencing-UI/blob/main/web/src/app/services/appid-authentication.service.ts

Describe the solution you'd like

Take out the credentials into .env file

Tasks

FYI @demilolu

@upkarlidder upkarlidder added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Sep 17, 2021
@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Oct 27, 2021
@XiangZhang0216
Copy link

Just curious, there are typescript files for environment variables in the web > src >environments directory, would it be better to just make fields for the credentials there?

@github-actions github-actions bot removed the stale label Jan 30, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed stale
Projects
Status: Backlog
Development

No branches or pull requests

2 participants