Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve OTP code to handle session data in OneTimePasswordVerifyTrait not in LoginTrait #995

Open
rochamarcelo opened this issue Mar 19, 2022 · 2 comments
Open

Improve OTP code to handle session data in OneTimePasswordVerifyTrait not in LoginTrait #995

rochamarcelo opened this issue Mar 19, 2022 · 2 comments
Labels
improvement

Comments

@rochamarcelo
Copy link
Collaborator

This is related to #988 and more items.

  • Move session delete $this->getRequest()->getSession()->delete(AuthenticationService::TWO_FACTOR_VERIFY_SESSION_KEY);
    from LoginTrait::login to OneTimePasswordVerifyTrait
  • On verification page instead of redirecting to login after invalid code submit we should ask the code again
@ajibarra
Copy link
Member

@rochamarcelo is this still valid?

@rochamarcelo
Copy link
Collaborator Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajibarra @rochamarcelo