Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user register with duplicate email, you can add a specific message #658

Open
vnt opened this issue Feb 21, 2018 · 3 comments
Open

user register with duplicate email, you can add a specific message #658

vnt opened this issue Feb 21, 2018 · 3 comments

Comments

@vnt
Copy link

vnt commented Feb 21, 2018

Hi,
if you try make a registration with an email already used, you receive the generic message (the user could not be saved).
Is it posibile add a specific message for this exception?
Ex: this email is already associated with another user.

Thanks a lot
D.

@llincoln
Copy link

My thoughts: This would confirm to a potential hacker that the email address does exist which is generally frowned upon.

https://www.owasp.org/index.php/Authentication_Cheat_Sheet#Authentication_and_Error_Messages

Maybe its possible to provide a token that can be overridden if this is the desired behaviour?

@vnt
Copy link
Author

vnt commented Feb 23, 2018

I think usability comes first.
If the user does not understand the reason for the error it could be a problem.

@llincoln
Copy link

llincoln commented Feb 23, 2018

This is perhaps an opportunity to get the best of both, a configurable setting that controls the verbosity of feedback messages would be a really nice feature. The tokenized strings containing the sort of feedback you are looking for is already in the exceptions thrown by the validate method of RegisterBehaviour.

I think usability comes first

In an ideal world I would agree, usability is king :) but where I work though my head would be on a stick for suggesting that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants