Code Quality Feedback for A0143873Y

[xpdavid]

Main

public class ClockTime {
    //private final Logger logger = LogsCenter.getLogger(ClockTime.class);

    public static final String MESSAGE_CLOCKTIME_CONSTRAINTS =
            "Clock time of task should be 24-hour form, eg: 23:59";

Comment out code?

/**
 * Represents a Task's time in the Tasklist.
 * Guarantees: immutable; is valid as declared in {@link #isValidClockTime(String)}
 */

public class ClockTime {
    //private final Logger logger = LogsCenter.getLogger(ClockTime.class);

There should not be an empty line between method body and Javadoc.

It seems that you don't have enough main code in the collate file. Hope you will work more on the main code.

Test

@Test
    public void isValidClockTime() {
        // blank clock time
        assertFalse(ClockTime.isValidClockTime("")); // empty string
        assertFalse(ClockTime.isValidClockTime(" ")); // spaces only

Test case naming conversion does not follow the coding standard. featureUnderTest_testScenario_expectedBehavior()

Also, it seems that you don't have enough test code in the collate file. Hope you will work more on the test code.