Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep image extent #38

Open
savmickael opened this issue Aug 9, 2018 · 1 comment
Open

Keep image extent #38

savmickael opened this issue Aug 9, 2018 · 1 comment

Comments

@savmickael
Copy link
Contributor

When we zoom or dezoom an image which used a center pixel convention, the geographical extent of the image is modified. If we support translation #10, it could be nice to provide an option to keep the same extent or at minimum keep the same UL.

A good example is when we deal with Sentinel-2 data. The 10m and 20m bands didn't use the same grid so a zoom from 20m to 10m lead to an image with a UL which is different. It is good mathematical behavior but quite confusing for end user.

@dumasl
Copy link
Contributor

dumasl commented Aug 9, 2018

I am afraid #10 will not be able to cover this scenario because Sirius shall not be allowed to provide data outside of the input image definition.

In other words, and using your example, say you have a 20m Sentinel2 and you upsample it by a factor 2 then what you get is a 20m Sentinel upsampled by a factor 2:

  • this means the original samples are conserved : same radiometry and same centre georef.
  • then, between two consecutive original samples you get one new sample.
    However, top left corner geolocation has changed because the first pixel, though it remains the same, is twice smaller.

To compare this now 10m Sentinel2 with an original 10m Sentinel2 you could translate the Sirius output by 5cm in both directions when #10 is done. But you would then have to crop the original 10m Sentinel2 you wish to compare you data with to get rid off its first & last rows and cols because you won't have them with Sirius translated output.

We could ask Sirius to create data outside of the original input scope. I assume it would/could be done by mirroring the input before resampling.
While this is not a tricky task, we need to define carefully what kind of parameters Sirius should provide to users. We do not want to confuse him and the very first message should be that Sirius upsamples and downsamples but it does not split nor does it averages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants